Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add brew formula #178

Closed
wants to merge 6 commits into from
Closed

Add brew formula #178

wants to merge 6 commits into from

Conversation

reetasingh
Copy link
Contributor

@reetasingh reetasingh commented Apr 8, 2024 •
edited
Loading

Fix #142

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 8, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 8, 2024
@reetasingh reetasingh mentioned this pull request Apr 9, 2024
Closed
@reetasingh reetasingh marked this pull request as ready for review April 10, 2024 22:24
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2024
@k8s-ci-robot k8s-ci-robot requested a review from dims April 10, 2024 22:24
@reetasingh reetasingh marked this pull request as draft April 10, 2024 22:43
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 11, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 13, 2024
cprivitere
cprivitere approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@cprivitere cprivitere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cprivitere, reetasingh
Once this PR has been reviewed and has the lgtm label, please assign aniruddha2000 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cprivitere
Copy link
Member

@reetasingh you able to take it out of draft? Or is more work still needed? It seemed good to me.

@cprivitere
Copy link
Member

/test all

@reetasingh reetasingh closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cprivitere cprivitere cprivitere approved these changes

@rakshitgondwal rakshitgondwal Awaiting requested review from rakshitgondwal

@rjsadow rjsadow Awaiting requested review from rjsadow

@dims dims Awaiting requested review from dims

Assignees

@cprivitere cprivitere

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a brew repo
3 participants
@reetasingh @k8s-ci-robot @cprivitere