Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable UUID check on xfs #164

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Disable UUID check on xfs #164

merged 1 commit into from
Oct 4, 2023

Conversation

jsafrane
Copy link
Contributor

Add nouuid mount option when mounting xfs to disable checks of filesystem UUIDs. This allows a xfs volume and its clone (or restored snapshot) to be mounted on the same node - they will have the same UUID, yet they're separate volumes.

@jsafrane
Disable UUID check on xfs
8229698 
Add 'nouuid' mount option when mounting xfs to disable checks of filesystem
UUIDs. This allows a xfs volume and its clone (or restored snapshot) to be
mounted on the same node - they will have the same UUID.
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 31, 2023
@coveralls
Copy link

coveralls commented Jul 31, 2023 •
edited
Loading

Coverage Status

coverage: 83.303% (+0.001%) from 83.302% when pulling 8229698 on jsafrane:fix-xfs into decb9df on kubernetes-sigs:master.

@jsafrane
Copy link
Contributor Author

jsafrane commented Aug 2, 2023

/check-cla

@jsafrane
Copy link
Contributor Author

jsafrane commented Aug 2, 2023

/test all

@jsafrane
Copy link
Contributor Author

jsafrane commented Aug 2, 2023

/test EasyCLA

@k8s-ci-robot
Copy link
Contributor

@jsafrane: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-ibm-vpc-block-csi-driver-build
  • /test pull-ibm-vpc-block-csi-driver-sanity
  • /test pull-ibm-vpc-block-csi-driver-unit
  • /test pull-ibm-vpc-block-csi-driver-verify

Use /test all to run the following jobs that were automatically triggered:

  • pull-ibm-vpc-block-csi-driver-build
  • pull-ibm-vpc-block-csi-driver-unit
  • pull-ibm-vpc-block-csi-driver-verify

In response to this:

/test EasyCLA

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane jsafrane closed this Aug 2, 2023
@jsafrane jsafrane reopened this Aug 2, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 2, 2023
@jsafrane
Copy link
Contributor Author

jsafrane commented Aug 2, 2023

@arahamad @ambiknai, PTAL. A similar fix was implemented in other CSI drivers, e.g. AWS EBS or GCP PD.

@ambiknai
Copy link
Contributor

ambiknai commented Aug 2, 2023

@arahamad @ambiknai, PTAL. A similar fix was implemented in other CSI drivers, e.g. AWS EBS or GCP PD.

Hi @jsafrane
Thank you for the PR !! We will go through and come back.

@jsafrane
Copy link
Contributor Author

@arahamad can you please take a look again?

@jsafrane
Copy link
Contributor Author

jsafrane commented Oct 3, 2023

@arahamad, @ambiknai @spzala @bradtopol can you please take a look?

@arahamad
Copy link
Contributor

arahamad commented Oct 3, 2023

@arahamad, @ambiknai @spzala @bradtopol can you please take a look?

@jsafrane , changes looks fine, although block storage has device ID as well but we are always mounting with device path to it looks good.
I know this will work, Just to make sure this flag always work across supported OS on IKS cluster, @ambiknai can you please help to verify these changes on our supported cluster versions.

@ambiknai
Copy link
Contributor

ambiknai commented Oct 3, 2023

@jsafrane @arahamad I will have the results ready by tomorrow.

arahamad
arahamad approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@arahamad arahamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ambiknai tested and result looks good

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 4, 2023
@arahamad arahamad requested review from ambiknai and removed request for bradtopol and ambiknai October 4, 2023 12:57
ambiknai
ambiknai approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@ambiknai ambiknai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in IBM Managed IKS and ROKS clusters.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ambiknai, arahamad, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0c73fc6 into kubernetes-sigs:master Oct 4, 2023
6 checks passed
jsafrane added a commit to jsafrane/ibm-vpc-block-csi-driver that referenced this pull request Oct 11, 2023
@jsafrane
UPSTREAM: 164: Disable UUID check on xfs (kubernetes-sigs#164)
17a7400 
Add 'nouuid' mount option when mounting xfs to disable checks of filesystem
UUIDs. This allows a xfs volume and its clone (or restored snapshot) to be
mounted on the same node - they will have the same UUID.
openshift-ci bot added a commit to openshift/ibm-vpc-block-csi-driver that referenced this pull request Oct 11, 2023
@openshift-ci
Merge pull request #45 from jsafrane/4.15-xfs-mount
fbdfc85 
OCPBUGS-16920: UPSTREAM: 164: Disable UUID check on xfs (kubernetes-sigs#164)
@dobsonj dobsonj mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambiknai ambiknai ambiknai approved these changes

@arahamad arahamad arahamad approved these changes

Assignees

@arahamad arahamad

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jsafrane @coveralls @k8s-ci-robot @ambiknai @arahamad