Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make validate-nutanix-all failing #1254

Closed
mboersma opened this issue Aug 16, 2023 · 5 comments · Fixed by #1256
Closed

make validate-nutanix-all failing #1254

mboersma opened this issue Aug 16, 2023 · 5 comments · Fixed by #1256
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@mboersma
Copy link
Contributor

What steps did you take and what happened:

The validation check has been failing in PRs recently due to some misconfiguration with nutanix. You can check recent PRs for an example, or run this command:

docker run registry.k8s.io/scl-image-builder/cluster-node-image-builder-amd64:v0.1.18 validate-nutanix-all
...
Error: Failed to prepare build: "nutanix"

4 error(s) occurred:

* missing nutanix_endpoint
* missing cluster_name
* missing subnet in vm_nics 1
* missing nutanix_password


make: *** [Makefile:585: validate-nutanix-ubuntu-2004] Error 1
make: Leaving directory '/home/matt/projects/image-builder/images/capi'

What did you expect to happen:

All targets should validate without errors.

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 16, 2023
@AverageMarcus
Copy link
Member

Looks like it was this change released in v0.8.0

Maybe we should pin to v0.7.1 for now?

@AverageMarcus
Copy link
Member

I've opened #1256 to pin the version instead of removing the test.

@tuxtof
Copy link
Contributor

tuxtof commented Aug 17, 2023

@AverageMarcus why this test is launched as there is no nutanix platform behind fo launch a full e2e test

i have another PR who is coming who will pin the version to 0.8.x to use some new feature of the nutanix packer plugin

@tuxtof
Copy link
Contributor

tuxtof commented Aug 17, 2023

if you don't want to disable the test , i prefer to set default value , to validate the check

@AverageMarcus
Copy link
Member

If you can get a PR up with those required values etc added that'd be awesome! I didn't know enough about the platform to know what was needed so easiest was just to pin to what we were using before :)

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants