-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update qemu ubuntu-2204 image to use latest #1251
Update qemu ubuntu-2204 image to use latest #1251
Conversation
Welcome @mcbenjemaa! |
Hi @mcbenjemaa. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label ok-to-test |
@mcbenjemaa: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@mcbenjemaa: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
That's a flaky test, |
/retest |
@mcbenjemaa The test is not going to pass until #1255 is merged. See #1254 for details. |
Hello there @AverageMarcus 👋 |
Thanks for the info. |
Actually, I've just opened #1256 to pin the version rather than remove the test entirely. Will try and get that merged later today when the other maintainers are online. |
/retest |
|
/retest We need to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, sorry about all the CI noise!
ping @chrischdi @jichenjc for review
"iso_checksum_type": "sha256", | ||
"iso_url": "https://old-releases.ubuntu.com/releases/jammy/ubuntu-22.04.1-live-server-amd64.iso", | ||
"iso_url": "https://releases.ubuntu.com/jammy/ubuntu-22.04.2-live-server-amd64.iso", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a dead link. 22.04.3 got published.
Is there a more stable link we could rely on so when 22.04.4 gets published this does not get dead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
annoyingly, you either get 22.04.3 from releases, or 22.04.2 from old-releases.
https://old-releases.ubuntu.com/releases/jammy/ubuntu-22.04.2-live-server-arm64.iso ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to use the long term stable link imho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. It just means we'll always be at least 1 version behind but I think that's ok as users can always override the URL if they need to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ubuntu stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pined the link to https://old-releases.ubuntu.com/releases/jammy/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@mcbenjemaa could you squash these commits? |
4da110e
to
8ce6561
Compare
done |
😢
|
/retest We've just merged in the update for Nutanix today and it was working on that PR 🤔 |
Can you check again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Building ubuntu raw images taking too long, and sometimes fails,
when updated the default image to latest, it actually a way faster.
Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #
Additional context
Add any other context for the reviewers