-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
images/capi/packer/azure: allow building images from various SIG images #1028
images/capi/packer/azure: allow building images from various SIG images #1028
Conversation
96bb7cc
to
0828b12
Compare
/test pull-azure-sigs |
919fc0a
to
0d8eb7f
Compare
0d8eb7f
to
119cae2
Compare
This is ready for merging I think. |
Could add some docs to https://image-builder.sigs.k8s.io/capi/providers/azure.html on how to do this. /lgtm |
119cae2
to
3c68c69
Compare
Added some minimal docs. Let me know if you think there is a need for a whole section with some examples. |
The option has been added in wrong builder on Windows. Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>
Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>
3c68c69
to
cb445c0
Compare
While this PR adds support for all combinations, Flatcar team will be using building from the private SIGs for the time being and resulting images will be published into community SIGs. |
Thanks @invidian |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: invidian, jsturtevant The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I didn't expect such a quick merge, thanks! |
What this PR does / why we need it:
As far as I understand, right now it is only possible to build images
from Marketplace images. This patch actually enables building from the
community images, directly shared images and private SIGs.
Signed-off-by: Mateusz Gozdek mgozdekof@gmail.com
If one wants to build Flatcar image using SIG, one should create
packer.json
file with content similar to below:For the time being though, let's keep building Flatcar from Marketplace image until we consider community galleries stable.
Additional context
Related to kubernetes-sigs/cluster-api-provider-azure#2890.
CC @jepio @johananl