Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Ubuntu 22.04 ISO URLs to use latest stable URLs #1438

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Update Ubuntu 22.04 ISO URLs to use latest stable URLs #1438

merged 1 commit into from
Apr 18, 2024

Conversation

AverageMarcus
Copy link
Member

@AverageMarcus AverageMarcus commented Apr 5, 2024 •
edited

Change description

This updates all the Ubuntu 22.04 ISO URLs to point to the latest available version using an URL that wont break when a new release is available.

Updated 22.04 to latest: 22.04.5

Related issues

Additional context

I haven't updated the Ubuntu 20.04 ISO urls as they would also require changes away from the legacy server images.

I haven't updated qemu-ubuntu-2304.json as currently the release is beta as far as I can tell and doesn't yet have the stable URLs available.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 5, 2024
@AverageMarcus AverageMarcus changed the title Update Ubuntu 20.04 & 22.04 ISO URLs to use latest stable URLs Update Ubuntu 22.04 ISO URLs to use latest stable URLs Apr 5, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 5, 2024
@AverageMarcus
Copy link
Member Author

Failed on Proton 🤨

/test pull-ova-all

@AverageMarcus
Copy link
Member Author 

Error verifying signature of: /var/cache/tdnf/photon-updates/rpms/x86_64/linux-5.10.212-4.ph4.x86_64.rpm\nError processing package: x86_64/linux-5.10.212-4.ph4.x86_64.rpm\nError(1514) : RPM is signed but failed to match with known keys. Use --nogpgcheck to ignore.

😞

@AverageMarcus
Copy link
Member Author

/retest

This was referenced Apr 8, 2024
Merged
Closed
@AverageMarcus
Copy link
Member Author

/retest

1 similar comment
@AverageMarcus
Copy link
Member Author

/retest

@AverageMarcus
Copy link
Member Author

/assign @mboersma @drew-viles

mboersma
mboersma approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2024
@drew-viles
Copy link
Contributor

/approve

I'm on vacation/holiday at the moment so may be delayed responding to things.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: drew-viles

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2024
@AverageMarcus
Copy link
Member Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@AverageMarcus: The following commands are available to trigger required jobs:

  • /test json-sort-check
  • /test pull-azure-vhds
  • /test pull-goss-populate
  • /test pull-lint
  • /test pull-ova-all
  • /test pull-packer-validate

The following commands are available to trigger optional jobs:

  • /test pull-azure-sigs
  • /test pull-container-image-build
  • /test pull-image-builder-gcp-all

Use /test all to run the following jobs that were automatically triggered:

  • json-sort-check
  • pull-ova-all
  • pull-packer-validate

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AverageMarcus
Update Ubuntu 22.04 ISO URLs to use stable URLs
d8cfca0 
Signed-off-by: Marcus Noble <github@marcusnoble.co.uk>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2024
@AverageMarcus
Copy link
Member Author

Sorry, I had to force-push (with no changes) to unblock a stuck GitHub check. Could I please get a /lgtm again? 🙏

@drew-viles
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2024
@k8s-ci-robot k8s-ci-robot merged commit 76d4658 into kubernetes-sigs:main Apr 18, 2024
9 checks passed
@abhay-krishna abhay-krishna mentioned this pull request Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboersma mboersma mboersma approved these changes

@detiber detiber Awaiting requested review from detiber

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees

@mboersma mboersma

@drew-viles drew-viles

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AverageMarcus @drew-viles @k8s-ci-robot @mboersma