Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ubuntu 24.04 and docs for hcloud #1481

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Add ubuntu 24.04 and docs for hcloud #1481

merged 3 commits into from
Jun 4, 2024

Conversation

kranurag7
Copy link
Contributor

Change description

this commit does the following:

  • add docs for building hcloud snapshots (DO was taken as starting point for this)
  • add support for ubuntu 24.04

Related issues

  • Fixes #

Additional context

Details 

# truncated build logs 
==> hcloud: Running post-processor: manifest
Build 'hcloud' finished after 22 minutes 49 seconds.

==> Wait completed after 22 minutes 49 seconds

==> Builds finished. The artifacts of successful builds are:
--> hcloud: A snapshot was created: 'cluster-api-ubuntu-2404-v1.28.9-1717293966' (ID: 168091345)
--> hcloud: A snapshot was created: 'cluster-api-ubuntu-2404-v1.28.9-1717293966' (ID: 168091345)
  • screenshot in hcloud
    image

@kranurag7
add ubuntu 24.04 and docs for hcloud
cef8ffb 
this commit does the following:
- add docs for building hcloud snapshots
- add support for ubuntu 24.04

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 2, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @kranurag7. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 2, 2024
@mboersma
Copy link
Contributor

mboersma commented Jun 3, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 3, 2024
@kranurag7
make json-sort
bda3840 
Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
mboersma
mboersma reviewed Jun 3, 2024
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I just had a minor comment on the docs.

docs/book/src/capi/providers/hcloud.md Outdated Show resolved Hide resolved
@kranurag7 @mboersma
Update docs/book/src/capi/providers/hcloud.md
bd890c9 
Co-authored-by: Matt Boersma <Matt.Boersma@microsoft.com>
mboersma
mboersma approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2024
@mboersma
Copy link
Contributor

mboersma commented Jun 3, 2024

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 3, 2024
AverageMarcus
AverageMarcus reviewed Jun 4, 2024
View reviewed changes
images/capi/packer/hcloud/hcloud-config.json
@@ -3,5 +3,5 @@
"hcloud_location": "{{env `HCLOUD_LOCATION`}}",
"image_name": "cluster-api-{{user `build_name`}}-{{user `kubernetes_semver`}}-{{user `build_timestamp`}}",
"server_type": "cx21",
"token": "{{env `AZURE_CLIENT_ID`}}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 Nice catch!

AverageMarcus
AverageMarcus reviewed Jun 4, 2024
View reviewed changes
Copy link
Member

@AverageMarcus AverageMarcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AverageMarcus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2d4e497 into kubernetes-sigs:main Jun 4, 2024
13 checks passed
@kranurag7 kranurag7 deleted the kr/update-hcloud branch June 4, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AverageMarcus AverageMarcus AverageMarcus left review comments

@mboersma mboersma mboersma approved these changes

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

@kkeshavamurthy kkeshavamurthy Awaiting requested review from kkeshavamurthy

Assignees

@mboersma mboersma

@AverageMarcus AverageMarcus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kranurag7 @k8s-ci-robot @mboersma @AverageMarcus