Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vSphere projects from Boskos #1487

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Use vSphere projects from Boskos #1487

merged 1 commit into from
Jun 11, 2024

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Jun 7, 2024 •
edited

Signed-off-by: Stefan Büringer buringerst@vmware.com

Change description

This PR changes our e2e test setup to use Boskos to consume vsphere projects from VMC.

This is preparation for the upcoming migration to a community-owned vCenter environment

For more context, see: kubernetes-sigs/cluster-api-provider-vsphere#3040

Related issues

  • Fixes #

Additional context

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 7, 2024
@sbueringer sbueringer mentioned this pull request Jun 7, 2024
Closed
29 tasks
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 7, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2024
@sbueringer
Copy link
Member Author

Added tls thumbprint to the presets used for this job: kubernetes/test-infra#32716

@sbueringer
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 7, 2024
@sbueringer sbueringer changed the title [WIP] Use vSphere projects from Boskos Use vSphere projects from Boskos Jun 10, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 10, 2024
@sbueringer
Copy link
Member Author

sbueringer commented Jun 10, 2024 •
edited

/hold
only until kubernetes-sigs/cluster-api-provider-vsphere#3034 is merged

/assign @mboersma @kkeshavamurthy @kkeshavamurthy
Please take a look already, so we can merge once the CAPV PR is merged.

Please let me know if you need more information than is provided on the linked issues

@sbueringer
Copy link
Member Author

/assign @fabriziopandini @chrischdi

@sriramandev
Copy link
Contributor

Where can I find the Dockerfile for boskosctl image?

@sriramandev
Copy link
Contributor

Where can I find the Dockerfile for boskosctl image?

Got it... https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/pull/3034/files#

@sbueringer
Copy link
Member Author

There's also an issue linked in the linked issue which explains a bit more about the Boskos setup: kubernetes/k8s.io#6877

@sbueringer
Copy link
Member Author

/test pull-ova-all

mboersma
mboersma approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I'm not that familiar with vSphere, but these changes make sense to me overall.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2024
@sbueringer
Use vSphere projects from Boskos
26c6745 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2024
@chrischdi
Copy link
Member

/test pull-ova-all

1 similar comment
@sbueringer
Copy link
Member Author

/test pull-ova-all

@sbueringer
Copy link
Member Author

Can we get an approval for this PR? :) Thank you!

mboersma
mboersma approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2024
@chrischdi
Copy link
Member

/lgtm

@sbueringer
Copy link
Member Author

Thx!

Will merge once CAPV is merged (merge in progress there)

@sbueringer
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit bda3702 into kubernetes-sigs:main Jun 11, 2024
7 checks passed
@sbueringer sbueringer deleted the pr-boskos branch June 11, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@mboersma mboersma mboersma approved these changes

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

@kkeshavamurthy kkeshavamurthy Awaiting requested review from kkeshavamurthy

Assignees

@mboersma mboersma

@chrischdi chrischdi

@fabriziopandini fabriziopandini

@kkeshavamurthy kkeshavamurthy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sbueringer @sriramandev @chrischdi @k8s-ci-robot @mboersma @fabriziopandini @kkeshavamurthy