Skip to content

Commit

Permalink
Review remarks
Browse files Browse the repository at this point in the history
  • Loading branch information
mimowo committed Aug 9, 2024
1 parent c2d148c commit 13850e6
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions test/e2e/e2e_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ var _ = ginkgo.Describe("JobSet", func() {
})

// This test is added to test the JobSet transitions as Kueue would when:
// doing: resume in RF1 -> suspend -> resume in RF2.
// doing: resume in ResourceFlavor1 -> suspend -> resume in ResourceFlavor2.
// In particular, Kueue updates the PodTemplate on suspending and resuming
// the JobSet.
ginkgo.When("JobSet is suspended and resumed", func() {
Expand All @@ -145,7 +145,6 @@ var _ = ginkgo.Describe("JobSet", func() {

ginkgo.By("Create a suspended JobSet", func() {
js.Spec.Suspend = ptr.To(true)
js.Spec.TTLSecondsAfterFinished = ptr.To[int32](5)
gomega.Expect(k8sClient.Create(ctx, js)).Should(gomega.Succeed())
})

Expand All @@ -163,6 +162,10 @@ var _ = ginkgo.Describe("JobSet", func() {
})

ginkgo.By("Await for all Jobs to be active", func() {
// In this step the Pods remain Pending due to the nodeSelector
// which does not match any nodes. Still, JobSet considers
// and Jobs which have at least one Pending or Running Pod as
// active.
gomega.Eventually(func() int32 {
gomega.Expect(k8sClient.Get(ctx, jsKey, js)).Should(gomega.Succeed())
if js.Status.ReplicatedJobsStatus == nil {
Expand Down

0 comments on commit 13850e6

Please sign in to comment.