Skip to content

Commit

Permalink
Merge pull request #532 from googs1025/ut_fix
Browse files Browse the repository at this point in the history
use t.Errorf instead of t.Fatalf
  • Loading branch information
k8s-ci-robot authored Apr 19, 2024
2 parents 9dc4358 + 9df189b commit 15277dd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/controllers/ttl_after_finished_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ func TestCheckIfTTLExpired(t *testing.T) {
r := &JobSetReconciler{clock: tc.clock}
expired, err := checkIfTTLExpired(ctx, r.clock, tc.jobset)
if tc.expectErr != (err != nil) {
t.Fatalf("expected error: %v, got: %v", tc.expectErr, err)
t.Errorf("expected error: %v, got: %v", tc.expectErr, err)
}
if tc.expectErr && !strings.Contains(err.Error(), tc.expectErrStr) {
t.Errorf("expected error string '%s' to be in '%v'", tc.expectErrStr, err)
Expand Down

0 comments on commit 15277dd

Please sign in to comment.