update README.md and Dockerfile

Dockerfile

@@ -15,6 +15,7 @@ RUN go mod download
 COPY main.go main.go
 COPY api/ api/
 COPY pkg/controllers/ pkg/controllers/
+COPY pkg/util/cert/ pkg/util/cert/
 
 # Build
 # the GOARCH has not a default value to allow the binary be built according to the host where the command

README.md

@@ -5,13 +5,6 @@ JobSet: An API for managing a group of Jobs as a unit.
 # Installation
 
 ### Prerequisites
-[cert-manager](https://cert-manager.io/) is required to create certificates for the webhook. To install 
-it on your cluster, run the following command:
-```
-kubectl apply -f https://github.com/cert-manager/cert-manager/releases/download/v1.11.0/cert-manager.yaml
-```
-See more details about [cert-manager installation](https://cert-manager.io/docs/installation/).
-
 To install the JobSet CRD and deploy the controller on the cluster selected on your `~/.kubeconfig`, run the following commands:
 ```
 git clone https://github.com/kubernetes-sigs/jobset.git

main.go

@@ -19,7 +19,6 @@ package main
 import (
 	"flag"
 	"os"
-	"sigs.k8s.io/jobset/pkg/util/cert"
 
 	// Import all Kubernetes client auth plugins (e.g. Azure, GCP, OIDC, etc.)
 	// to ensure that exec-entrypoint and run can make use of them.
@@ -34,6 +33,7 @@ import (
 
 	jobset "sigs.k8s.io/jobset/api/v1alpha1"
 	"sigs.k8s.io/jobset/pkg/controllers"
+	"sigs.k8s.io/jobset/pkg/util/cert"
 	//+kubebuilder:scaffold:imports
 )
 
@@ -96,7 +96,9 @@ func main() {
 		os.Exit(1)
 	}
 
-	setupIndexes(mgr)
+	if err := controllers.SetupIndexes(mgr.GetFieldIndexer()); err != nil {
+		setupLog.Error(err, "unable to setup indexes")
+	}
 
 	go setupControllers(mgr, certsReady)
 
@@ -110,7 +112,8 @@ func main() {
 }
 
 func setupControllers(mgr ctrl.Manager, certsReady chan struct{}) {
-	// wait until the cert ready, until then we set up controllers
+	// The controllers won't work until the webhooks are operating,
+	// and the webhook won't work until the certs are all in places.
 	setupLog.Info("waiting for the cert generation to complete")
 	<-certsReady
 	setupLog.Info("certs ready")
@@ -139,9 +142,3 @@ func setupHealthzAndReadyzCheck(mgr ctrl.Manager) {
 		os.Exit(1)
 	}
 }
-
-func setupIndexes(mgr ctrl.Manager) {
-	if err := controllers.SetupIndexes(mgr.GetFieldIndexer()); err != nil {
-		setupLog.Error(err, "unable to setup indexes")
-	}
-}

test/integration/webhook/suite_test.go

@@ -35,6 +35,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/envtest"
 	logf "sigs.k8s.io/controller-runtime/pkg/log"
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
+
 	jobset "sigs.k8s.io/jobset/api/v1alpha1"
 	"sigs.k8s.io/jobset/pkg/controllers"
 )