Skip to content

Commit

Permalink
promote v1alpha1 to v1
Browse files Browse the repository at this point in the history
  • Loading branch information
kannon92 committed Apr 13, 2024
1 parent ec6aef7 commit 55fabfd
Show file tree
Hide file tree
Showing 133 changed files with 9,340 additions and 711 deletions.
9 changes: 5 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ help: ## Display this help.
manifests: controller-gen ## Generate WebhookConfiguration, ClusterRole and CustomResourceDefinition objects.
$(CONTROLLER_GEN) \
rbac:roleName=manager-role output:rbac:artifacts:config=config/components/rbac\
crd:generateEmbeddedObjectMeta=true output:crd:artifacts:config=config/crd/bases \
paths="./api/..."
$(CONTROLLER_GEN) \
rbac:roleName=manager-role output:rbac:artifacts:config=config/components/rbac\
Expand Down Expand Up @@ -240,9 +241,9 @@ code-generator:
.PHONY: openapi-gen
openapi-gen:
@GOBIN=$(PROJECT_DIR)/bin GO111MODULE=on $(GO_CMD) install k8s.io/code-generator/cmd/openapi-gen@latest
$(PROJECT_DIR)/bin/openapi-gen --go-header-file hack/boilerplate.go.txt -i sigs.k8s.io/jobset/api/jobset/v1alpha2 -p sigs.k8s.io/jobset/api/jobset/v1alpha2 --alsologtostderr
if [ $(GOPATH)/src/sigs.k8s.io/jobset/api/jobset/v1alpha2/openapi_generated.go != $(PROJECT_DIR)/api/jobset/v1alpha2/openapi_generated.go ]; then \
mv $(GOPATH)/src/sigs.k8s.io/jobset/api/jobset/v1alpha2/openapi_generated.go $(PROJECT_DIR)/api/jobset/v1alpha2/openapi_generated.go; \
$(PROJECT_DIR)/bin/openapi-gen --go-header-file hack/boilerplate.go.txt -i sigs.k8s.io/jobset/api/jobset/v1 -p sigs.k8s.io/jobset/api/jobset/v1 --alsologtostderr
if [ $(GOPATH)/src/sigs.k8s.io/jobset/api/jobset/v1/openapi_generated.go != $(PROJECT_DIR)/api/jobset/v1/openapi_generated.go ]; then \
mv $(GOPATH)/src/sigs.k8s.io/jobset/api/jobset/v1/openapi_generated.go $(PROJECT_DIR)/api/jobset/v1/openapi_generated.go; \
fi

.PHONY: envtest
Expand Down Expand Up @@ -296,4 +297,4 @@ golangci-lint: ## Download golangci-lint locally if necessary.
GOTESTSUM = $(shell pwd)/bin/gotestsum
.PHONY: gotestsum
gotestsum: ## Download gotestsum locally if necessary.
@GOBIN=$(PROJECT_DIR)/bin GO111MODULE=on $(GO_CMD) install gotest.tools/gotestsum@v1.8.2
@GOBIN=$(PROJECT_DIR)/bin GO111MODULE=on $(GO_CMD) install gotest.tools/gotestsum@v1.8.2
4 changes: 2 additions & 2 deletions PROJECT
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ resources:
domain: x-k8s.io
group: jobset
kind: JobSet
path: sigs.k8s.io/jobset/api/jobset/v1alpha2
version: v1alpha2
path: sigs.k8s.io/jobset/api/jobset/v1
version: v1
webhooks:
defaulting: true
validation: true
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Take a look at the [concepts](https://jobset.sigs.k8s.io/docs/concepts/) page fo

## Production Readiness status

- ✔️ API version: v1alpha2, respecting [Kubernetes Deprecation Policy](https://kubernetes.io/docs/reference/using-api/deprecation-policy/)
- ✔️ API version: v1, respecting [Kubernetes Deprecation Policy](https://kubernetes.io/docs/reference/using-api/deprecation-policy/)
- ✔️ Maintains support for latest 3 Kubernetes minor versions.
- ✔️ Up-to-date [documentation](https://jobset.sigs.k8s.io/docs).
- ✔️ Test Coverage:
Expand Down
2 changes: 1 addition & 1 deletion api/jobset/v1alpha2/doc.go → api/jobset/v1/doc.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ limitations under the License.
// +kubebuilder:object:generate=true
// +groupName=jobset.x-k8s.io

package v1alpha2
package v1
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ See the License for the specific language governing permissions and
limitations under the License.
*/

// Package v1alpha2 contains API Schema definitions for the batch v1alpha2 API group
// Package v1 contains API Schema definitions for the batch v1 API group
// +kubebuilder:object:generate=true
// +groupName=jobset.x-k8s.io
package v1alpha2
package v1

import (
"k8s.io/apimachinery/pkg/runtime/schema"
Expand All @@ -23,7 +23,7 @@ import (

var (
// GroupVersion is group version used to register these objects
GroupVersion = schema.GroupVersion{Group: "jobset.x-k8s.io", Version: "v1alpha2"}
GroupVersion = schema.GroupVersion{Group: "jobset.x-k8s.io", Version: "v1"}

// SchemeGroupVersion is alias to GroupVersion for client-go libraries.
// It is required by pkg/client/informers/externalversions/...
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ limitations under the License.
*/

// +k8s:openapi-gen=true
package v1alpha2
package v1

import (
batchv1 "k8s.io/api/batch/v1"
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion api/jobset/v1alpha2/types.go → api/jobset/v1/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ limitations under the License.
This file is needed for kubernetes/code-generator/kube_codegen.sh script used in hack/update-codegen.sh.
*/

package v1alpha2
package v1

//+genclient

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 55fabfd

Please sign in to comment.