Use slice for errors

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>

pkg/controllers/jobset_controller.go

@@ -372,7 +372,7 @@ func (r *JobSetReconciler) restartPolicyRecreateAll(ctx context.Context, js *job
 func (r *JobSetReconciler) deleteJobs(ctx context.Context, jobsForDeletion []*batchv1.Job) error {
 	log := ctrl.LoggerFrom(ctx)
 	lock := &sync.Mutex{}
-	var finalErr error
+	var finalErrs []error
 	workqueue.ParallelizeUntil(ctx, parallelDeletions, len(jobsForDeletion), func(i int) {
 		targetJob := jobsForDeletion[i]
 		// Delete job. This deletion event will trigger another reconciliation,
@@ -381,12 +381,12 @@ func (r *JobSetReconciler) deleteJobs(ctx context.Context, jobsForDeletion []*ba
 		if err := r.Delete(ctx, targetJob, &client.DeleteOptions{PropagationPolicy: &backgroundPolicy}); client.IgnoreNotFound(err) != nil {
 			lock.Lock()
 			defer lock.Unlock()
-			finalErr = errors.Join(finalErr, err)
+			finalErrs = append(finalErrs, err)
 			return
 		}
 		log.V(2).Info("successfully deleted job", "job", klog.KObj(targetJob), "restart attempt", targetJob.Labels[targetJob.Labels[RestartsKey]])
 	})
-	return finalErr
+	return errors.Join(finalErrs...)
 }
 
 // updateStatus updates the status of a JobSet.