Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test grid should show all the tests successful or failure #137

Closed
Tracked by #145
kannon92 opened this issue May 11, 2023 · 7 comments · Fixed by #155
Closed
Tracked by #145

Test grid should show all the tests successful or failure #137

kannon92 opened this issue May 11, 2023 · 7 comments · Fixed by #155
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@kannon92
Copy link
Contributor

https://k8s-testgrid.appspot.com/sig-apps#pull-jobset-test-integration-main only shows a single row which is not ideal.

We enabled this in Kueue and it has helped identify flaky tests.

I think uploading junit reports for each test was all we needed for support in Kueue.

@kannon92
Copy link
Contributor Author

@kannon92
Copy link
Contributor Author

kubernetes-sigs/kueue#423 Approach for how I did this for Kueue

@kannon92
Copy link
Contributor Author

/good-first-issue
/help

@k8s-ci-robot
Copy link
Contributor

@kannon92:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels May 11, 2023
@clearnicki
Copy link
Contributor

If this is still available - I'd like to work on this.

/assign

@kannon92
Copy link
Contributor Author

If this is still available - I'd like to work on this.

/assign

Thanks for taking this! Please feel free to reach out to me if you have questions.

@clearnicki
Copy link
Contributor

@kannon92 hey - thanks! I made PR #155 do you want to check it out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants