Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for use of podman for running containers in development. #332

Closed
kannon92 opened this issue Nov 14, 2023 · 3 comments · Fixed by #333
Closed

Allow for use of podman for running containers in development. #332

kannon92 opened this issue Nov 14, 2023 · 3 comments · Fixed by #333

Comments

@kannon92
Copy link
Contributor

We migrated the generation of the python sdk code to use docker. Currently, we require that docker must be enabled on host to build.

Kubernetes/Kind actually allow the use of podman rather than docker.

It would be ideal to allow for either Podman or Docker for running the test code.

kehannon@kehannon-thinkpadp1gen4i:~/Work/jobset$ make test
test -s /home/kehannon/Work/jobset/bin/controller-gen && /home/kehannon/Work/jobset/bin/controller-gen --version | grep -q v0.11.4 || \
GOBIN=/home/kehannon/Work/jobset/bin go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.11.4
/home/kehannon/Work/jobset/bin/controller-gen \
        rbac:roleName=manager-role output:rbac:artifacts:config=config/components/rbac\
        crd:generateEmbeddedObjectMeta=true output:crd:artifacts:config=config/components/crd/bases\
        webhook output:webhook:artifacts:config=config/components/webhook\
        paths="./..."
go fmt ./...
go vet ./...
test -s /home/kehannon/Work/jobset/bin/setup-envtest || GOBIN=/home/kehannon/Work/jobset/bin go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
echo "testing Python SDK..."
testing Python SDK...
./hack/python-sdk/test-sdk.sh
ERROR: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
make: *** [Makefile:130: test-python-sdk] Error 1
@danielvegamyhre
Copy link
Contributor

danielvegamyhre commented Nov 22, 2023

Perhaps this is somewhat embarrassing but I actually haven't ever heard of Podman, how widely used is it? Changes look simple enough so I am fine with this (as long as we still default to docker, which I can see in the PR we do) but I'm just curious.

@kannon92
Copy link
Contributor Author

Pod man is gaining traction. It’s a container engine written by Redhat and uses a lot of the same code that crio uses. It works a bit better with fedora/redhat.

@kannon92
Copy link
Contributor Author

kannon92 commented Dec 4, 2023

Perhaps this is somewhat embarrassing but I actually haven't ever heard of Podman, how widely used is it? Changes look simple enough so I am fine with this (as long as we still default to docker, which I can see in the PR we do) but I'm just curious.

I asked around and I was told that Podman has millions of users and podman desktop has been downloaded over 700k times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants