-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow for podman to be used for running tests #333
Conversation
I think there may be an issue with subbing podman for docker due to some missing commands in podman. This PR should allow for running tests but we require docker in some places. |
@danielvegamyhre wdyt about this PR? Podman has over 12k stars so it seems to be well used. On fedora, it is the default container engine so it would be nice to not require docker. Kind also has some support for podman. |
Looks good to me! Did you manually test that the defaulting to docker works? |
Yea, I tested both cases. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielvegamyhre, kannon92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@danielvegamyhre when you get a chance, can you give a lgtm also? |
/lgtm |
Fixes #332
This allows one to substitute podman over docker.