Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for podman to be used for running tests #333

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

kannon92
Copy link
Contributor

@kannon92 kannon92 commented Nov 14, 2023

Fixes #332

This allows one to substitute podman over docker.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 14, 2023
@kannon92
Copy link
Contributor Author

I think there may be an issue with subbing podman for docker due to some missing commands in podman. This PR should allow for running tests but we require docker in some places.

@kannon92
Copy link
Contributor Author

kannon92 commented Dec 4, 2023

@danielvegamyhre wdyt about this PR?

Podman has over 12k stars so it seems to be well used. On fedora, it is the default container engine so it would be nice to not require docker.

Kind also has some support for podman.

@danielvegamyhre
Copy link
Contributor

Looks good to me! Did you manually test that the defaulting to docker works?

@kannon92
Copy link
Contributor Author

kannon92 commented Dec 4, 2023

Looks good to me! Did you manually test that the defaulting to docker works?

Yea, I tested both cases.

@danielvegamyhre
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielvegamyhre, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2023
@kannon92
Copy link
Contributor Author

kannon92 commented Dec 4, 2023

@danielvegamyhre when you get a chance, can you give a lgtm also?

@danielvegamyhre
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit 39827b9 into kubernetes-sigs:main Dec 4, 2023
@danielvegamyhre danielvegamyhre mentioned this pull request Dec 12, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for use of podman for running containers in development.
3 participants