Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle race conditions in exclusive placement #341

Closed
Tracked by #239
danielvegamyhre opened this issue Nov 22, 2023 · 1 comment · Fixed by #342
Closed
Tracked by #239

Handle race conditions in exclusive placement #341

danielvegamyhre opened this issue Nov 22, 2023 · 1 comment · Fixed by #342
Assignees

Comments

@danielvegamyhre
Copy link
Contributor

Now that #310 has been addressed via the pod webhook approach, we need to handle certain race conditions which can occur in this strategy.

Consider the following race condition:

  1. Leader of Job 1 getting killed right after we set the nodeSelector on its follower pods
  2. At the same time, leader of Job 2 lands on the same slice before any of Job 1's followers get to schedule on it. In this case Job 1's followers will have a nodeSelector on the node pool, but will never schedule because of the anti-affinity of Job 2's leader.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant