-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pod reconciler to handle race conditions in exclusive placement #342
Update pod reconciler to handle race conditions in exclusive placement #342
Conversation
/hold until #340 is merged |
/retest webhook still isn't ready after 10min somewhat frequently in our CI e2e tests, I think we need to bump the test infra CPU/memory resources. |
331d34d
to
06c9aff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l have few more comments, will discuss f2f
…delete follower pods when there is a placement violation
dac90ab
to
3084b9e
Compare
/retest |
Looks good, but lets first continue our investigation on the pod reconciler's update events and manual tests. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just a couple of nits
@ahg-g I cleaned up the logging in the webhook by removing 1 superfluous log line and marking the others at V(3), which is higher than the controller logs which are V(2), so the user can choose to not view them unless they want to debug something. |
/label tide/merge-method-squash |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, danielvegamyhre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #341
In the following changes, we aim to enforce that for JobSets using exclusive placement, pods that belong to the same job are scheduled on the same topology domain exclusively. We do this by performing the following steps:
I will add an e2e test forcing the race condition to happen and verifying the reconciler handles it in a follow-up PR.