Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration Test Cleanup: #396

Open
kannon92 opened this issue Feb 6, 2024 · 2 comments
Open

Integration Test Cleanup: #396

kannon92 opened this issue Feb 6, 2024 · 2 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@kannon92
Copy link
Contributor

kannon92 commented Feb 6, 2024

This ticket will track some improvements we can make to the integration tests.

#246 (comment)

it would be great to change updates to steps and also change the struct from update to step.

and we should add a map of jobs to updates so we don't assume order. ReplicatedJobStatus order is enforced by sorting by name but that is a bit janky.
@danielvegamyhre danielvegamyhre added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Feb 16, 2024
@prashantrewar
Copy link

Hey @kannon92, Is this issue still up for grabs? I would love to work on this.

@jedwins1998
Copy link
Contributor

@prashantrewar the issue is still open as far as I am aware. Feel free to claim it.

@danielvegamyhre danielvegamyhre mentioned this issue Jun 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kannon92 @danielvegamyhre @prashantrewar @jedwins1998