Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Startup policy implementation #246

Merged
merged 25 commits into from
Feb 13, 2024
Merged

Startup policy implementation #246

merged 25 commits into from
Feb 13, 2024

Conversation

kannon92
Copy link
Contributor

@kannon92 kannon92 commented Aug 4, 2023

Implementation for #244

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 4, 2023
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 4, 2023
@kannon92
Copy link
Contributor Author

kannon92 commented Aug 4, 2023 •
edited
Loading

I would like to keep design discussions on the KEP PR for now. I just find it hard to visualize all these items without some kind of implementation.

@kannon92 kannon92 force-pushed the startup-policy-implementation branch from 032acc4 to 0cbb6a6 Compare August 8, 2023 19:29
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2023
@kannon92 kannon92 force-pushed the startup-policy-implementation branch from 0cbb6a6 to c2e3d76 Compare August 18, 2023 20:51
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 18, 2023
@kannon92 kannon92 force-pushed the startup-policy-implementation branch from c2e3d76 to 234a87b Compare August 18, 2023 21:08
@kannon92 kannon92 changed the title WIP: Startup policy implementation Startup policy implementation Aug 24, 2023
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 24, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 13, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 20, 2023
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 20, 2023
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 26, 2023
@kannon92 kannon92 force-pushed the startup-policy-implementation branch from 09111a6 to 86ed229 Compare October 6, 2023 17:56
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2023
@kannon92 kannon92 force-pushed the startup-policy-implementation branch from fc4eb17 to 2b1f588 Compare November 13, 2023 21:07
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 14, 2023
@kannon92 kannon92 force-pushed the startup-policy-implementation branch from 790e310 to 302cc22 Compare November 14, 2023 14:42
@kannon92 kannon92 force-pushed the startup-policy-implementation branch from 040b360 to e3539bb Compare February 12, 2024 15:03
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 12, 2024 •
edited
Loading

@kannon92: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-jobset-test-e2e-main-1-25 040b360 link true /test pull-jobset-test-e2e-main-1-25

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kannon92
Copy link
Contributor Author

@danielvegamyhre @ahg-g I think I've addressed all outstanding items. PTAL when you can.

danielvegamyhre
danielvegamyhre reviewed Feb 12, 2024
View reviewed changes
Copy link
Contributor

@danielvegamyhre danielvegamyhre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after this final change!

test/integration/controller/jobset_controller_test.go Outdated Show resolved Hide resolved
test/integration/controller/jobset_controller_test.go Outdated Show resolved Hide resolved
ahg-g
ahg-g reviewed Feb 12, 2024
View reviewed changes
pkg/controllers/jobset_controller.go
return r.ensureCondition(ctx, ensureConditionOpts{
jobset: js,
eventType: corev1.EventTypeNormal,
forceFalseUpdate: false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is false by default, so no need to set it. Here and many other places in the file

@ahg-g
Copy link
Contributor

ahg-g commented Feb 13, 2024

/lgtm
/approve

I will send a follow up PR for the remaining comment.

Thanks @kannon92 !

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2024
@ahg-g
Copy link
Contributor

ahg-g commented Feb 13, 2024

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2024
@danielvegamyhre
Copy link
Contributor

Thanks for the changes, LGTM! Appreciate your work on this @kannon92!

@ahg-g
Copy link
Contributor

ahg-g commented Feb 13, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit bf2f217 into kubernetes-sigs:main Feb 13, 2024
9 checks passed
@danielvegamyhre danielvegamyhre mentioned this pull request Feb 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g ahg-g left review comments

@danielvegamyhre danielvegamyhre danielvegamyhre left review comments

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kannon92 @ahg-g @k8s-ci-robot @danielvegamyhre