Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests to jobset success policy functions #491

Closed
danielvegamyhre opened this issue Apr 2, 2024 · 1 comment · Fixed by #501
Closed

Add unit tests to jobset success policy functions #491

danielvegamyhre opened this issue Apr 2, 2024 · 1 comment · Fixed by #501
Assignees
@zhifei92
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@danielvegamyhre
Copy link
Contributor

What would you like to be added:

Add unit tests to jobset success policy functions here

Why is this needed:
To improve test coverage
@danielvegamyhre danielvegamyhre added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Apr 2, 2024
Dibyanshuaman added a commit to Dibyanshuaman/jobset that referenced this issue Apr 3, 2024
@Dibyanshuaman
Add unit tests to jobset success policy functions kubernetes-sigs#491
5d348e1
@zhifei92
Copy link
Contributor

zhifei92 commented Apr 8, 2024

/assign

Dibyanshuaman added a commit to Dibyanshuaman/jobset that referenced this issue Apr 8, 2024
@Dibyanshuaman
kubernetes-sigs#491 added all test cases to seprate file as instructed
53d2b4e
@zhifei92 zhifei92 mentioned this issue Apr 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhifei92 zhifei92

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add unit tests to jobset success policy functions zhifei92/jobset
2 participants
@zhifei92 @danielvegamyhre