-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pyproject.toml and cleanup sdk installation #223
Add pyproject.toml and cleanup sdk installation #223
Conversation
@ahg-g and @danielvegamyhre IMO we should maybe consider this as a patch release to 0.2.0. 0.2.0 package isn't capable of being installed as a package in a virtual environment. |
Agreed, we can include this in a v0.2.1 release. Thanks for putting this together! |
@kannon92 I checked out this PR locally and tried to install the jobset package in my virtualenv and encountered this error:
did you experience this? |
@kannon92 I was able to resolve the issue in my previous comment by updating the pyproject.toml per this stackoverflow post: https://stackoverflow.com/questions/72294299/multiple-top-level-packages-discovered-in-a-flat-layout Can we add this to the PR please? |
Another issue: I have successfully installed the
|
/assign |
I am unable to reproduce this actually. What version of python are you using? And are you using a virtual environment or installing into system python? |
I am using a virtualenv with Python 3.11.2 |
Interesting, I can import I copied the
|
I think i found a small bug in the script, I will submit a quick PR |
See #225 with the fix |
I notice in my venv site-packages, for every package besides jobset there is a pattern of 2 directories existing:
|
Can you try again? I found a bug where I wasn't installing all the modules. |
@kannon92 Nice the import issue seems to be resolved |
/label tide/merge-method-squash thanks for doing this! i'll patch this in to the last release as v0.2.1 and include #224 as well |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielvegamyhre, kannon92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…pstream-release-0.2 Automated cherry pick of #223: use pyproject.toml
This PR adds
pyproject.toml
instead of setup.py. The python community is moving to adopt pyproject.toml. Another reason I moved to this is that the tool chain we use to generate the python code has an invalid setup.py.You can install our package like
python3 -m pip install sdk/python/.
with thepyproject.toml
file.@danielvegamyhre this should fix your issue with /tmp and egg files.