Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add patch rbac for events #248

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

kannon92
Copy link
Contributor

@kannon92 kannon92 commented Aug 5, 2023

Found this error when testing StartupPolicy.

We sometimes get an invalid patch for events since we don't allow patching of events.

Add a RBAC for patch for events.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 5, 2023
@danielvegamyhre
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielvegamyhre, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 954d1f0 into kubernetes-sigs:main Aug 7, 2023
@kannon92
Copy link
Contributor Author

kannon92 commented Aug 8, 2023

@danielvegamyhre do you think this worthy of a cherry-pick into 0.2.0?

@danielvegamyhre
Copy link
Contributor

@kannon92 Can you prepare a cherry pick into release-0.2 branch for this? I want to cut a v0.2.1 release tomorrow

@kannon92
Copy link
Contributor Author

kannon92 commented Aug 16, 2023

Done.

k8s-ci-robot added a commit that referenced this pull request Aug 16, 2023
…pstream-release-0.2

Automated cherry pick of #248: add patch rbac for events
@danielvegamyhre danielvegamyhre mentioned this pull request Dec 12, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants