add suspend to replicated job status #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
kannon92
force-pushed
the
add-suspend-status
branch
2 times, most recently
from
fb0186b to
c5bbb74
Compare
k8s-ci-robot
added
the
needs-rebase
kannon92
force-pushed
the
add-suspend-status
branch
from
c5bbb74 to
ee28ad7
Compare
k8s-ci-robot
removed
the
needs-rebase
kannon92
force-pushed
the
add-suspend-status
branch
from
ee28ad7 to
f5d9a0f
Compare
Merged
|
@danielvegamyhre @ahg-g As we discussed in the startup policy KEP, I'm not sure I will go this route but curious what you think of this. If you are happy with, can we merge it into main? |
|
Thanks, this is great! /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, kannon92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #244, I think adding a status field for suspend would be helpful if we go this route.
I added a field for suspend and updated a few of our tests to directly compare against status field.