add golangci and fix some minor items #254
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
/retest |
| return true | ||
| }, timeout, interval).Should(gomega.BeTrue()) | ||
| return nil | ||
| }, timeout, interval).Should(gomega.Succeed()) |
There was a problem hiding this comment.
are these changes suggested by the linter?
There was a problem hiding this comment.
I enabled the linter and I saw there were were a few minor items to fix to get the linter to pass.
All changes (outside of Makefile) are related to the linter.
| @@ -122,9 +122,8 @@ var _ = ginkgo.Describe("JobSet controller", func() { | |||
| } | |||
|
|
|||
| type testCase struct { | |||
| makeJobSet func(*corev1.Namespace) *testing.JobSetWrapper | |||
| jobSetCreationShouldFail bool | |||
There was a problem hiding this comment.
just to clarify, is this removed because it isn't used anywhere anymore? remnant of an old test case we removed?
|
/lgtm |
k8s-ci-robot
added
lgtm
k8s-ci-robot
removed
lgtm
k8s-ci-robot
added
the
size/L
|
@danielvegamyhre could use another lgtm when you get a chance. Had to do a rebase. |
| @@ -22,11 +22,12 @@ import ( | |||
| "k8s.io/apimachinery/pkg/runtime" | |||
| "k8s.io/apimachinery/pkg/util/validation" | |||
| "k8s.io/apimachinery/pkg/util/validation/field" | |||
| "k8s.io/utils/pointer" | |||
| "k8s.io/utils/ptr" | |||
There was a problem hiding this comment.
@danielvegamyhre linter exposed that I didn't completely remove pointer. Linter will yell at us if we use deprecated packages so I missed this on the old PR. Linter FTW! ;)
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielvegamyhre, kannon92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I saw that we don't have golangci so I went ahead and added that to our checks.
Took a sample config from Kueue for starters and fixed a few minor issues related to the linter.