Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add source to pytorch mnist example #256

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Add source to pytorch mnist example #256

merged 1 commit into from
Aug 15, 2023

Conversation

danielvegamyhre
Copy link
Contributor

@danielvegamyhre danielvegamyhre commented Aug 15, 2023 •
edited
Loading

Fixes #257

The purpose of these changes is to add the source code and Dockerfile for the PyTorch MNIST example, as well as restructure the example folder to better organize these new files.

@danielvegamyhre
Copy link
Contributor Author

cc @kannon92

@k8s-ci-robot k8s-ci-robot requested a review from ahg-g August 15, 2023 19:23
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielvegamyhre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 15, 2023
kannon92
kannon92 reviewed Aug 15, 2023
View reviewed changes
Copy link
Contributor

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Do you think there should be some way of building these images and pushing to registry?

Otherwise I think it looks good to me. If you want a lgtm before @ahg-g lmk.

@danielvegamyhre
Copy link
Contributor Author

@kannon92 I created an issue to set up a CloudBuild to build container images used in these examples on every merge #258

In the meantime feel free to LGTM if you feel this is ready.

@kannon92
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit 824649f into kubernetes-sigs:main Aug 15, 2023
@danielvegamyhre danielvegamyhre mentioned this pull request Dec 12, 2023
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannon92 kannon92 kannon92 left review comments

@ahg-g ahg-g Awaiting requested review from ahg-g

Assignees

@kannon92 kannon92

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add source code and Dockerfiles for container images used in JobSet examples
3 participants
@danielvegamyhre @k8s-ci-robot @kannon92