Add node selector strategy for exclusive job placement per topology #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielvegamyhre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
size/M
ahg-g
reviewed
Sep 28, 2023
k8s-ci-robot
added
size/L
danielvegamyhre
force-pushed
the
label
branch
from
16d5417 to
6ab0768
Compare
ahg-g
reviewed
Sep 28, 2023
| @@ -0,0 +1,104 @@ | |||
| #!/usr/bin/python3 | |||
There was a problem hiding this comment.
some comment on how this script can be used would be good and the args they need to pass
There was a problem hiding this comment.
added. let me know if it is too detailed, or if perhaps i should include a concrete example use case?
|
/lgtm |
k8s-ci-robot
added
the
lgtm
danielvegamyhre
force-pushed
the
label
branch
from
a15b1a5 to
7ba3f58
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #312
Add node selector strategy for exclusive job placement per topology.
NodeSelectorStrategyKey is an annotation that acts as a flag, the value does not matter. If set, the JobSet controller will automatically inject nodeSelectors for the JobSetNameKey label to ensure exclusive job placement per topology, instead of injecting pod affinity/anti-affinites for this. The user must add the JobSet name node label to the desired topologies separately.
I manually verified the python script works on a test cluster.