Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update kind to 0.20.0 #359

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

kannon92
Copy link
Contributor

@dejanzele pointed out some issues with the setup and I can replicate it on latest version of kind.

Want to test it out in CI to verify my hypothesis.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 20, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 20, 2023
@kannon92
Copy link
Contributor Author

/test pull-jobset-test-e2e-main-1-29

@kannon92
Copy link
Contributor Author

/test pull-jobset-test-e2e-main-1-29
/test pull-jobset-test-e2e-main-1-28

@dejanzele
Copy link
Contributor

I don't know can amd64 or arm64 build of kind impact this somehow. I have issues in kind v0.20.0 go1.20.5 darwin/arm64 for sure. I'll try to validate on a linux amd64 machine.

@kannon92
Copy link
Contributor Author

/test pull-jobset-test-e2e-main-1-29
/test pull-jobset-test-e2e-main-1-28

@kannon92
Copy link
Contributor Author

I don't know can amd64 or arm64 build of kind impact this somehow. I have issues in kind v0.20.0 go1.20.5 darwin/arm64 for sure. I'll try to validate on a linux amd64 machine.

So the e2e tests sometimes see this error and the deployment doesn’t come up. I will see about installing it on a real kube cluster.

I don’t know why the e2e tests sometimes work and sometimes fail horribly…

@kannon92
Copy link
Contributor Author

/test pull-jobset-test-e2e-main-1-29
/test pull-jobset-test-e2e-main-1-28

@ahg-g
Copy link
Contributor

ahg-g commented Jan 15, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2024
@kannon92
Copy link
Contributor Author

/hold cancel

I put a hold on this because I wanted to see if this would cause more flakes or not. Didn't see that.

@kannon92
Copy link
Contributor Author

/hold cancel

@kannon92
Copy link
Contributor Author

/cancel hold

@kannon92 kannon92 changed the title WIP: update kind to 0.20.0 update kind to 0.20.0 Jan 16, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit 111b886 into kubernetes-sigs:main Jan 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants