Validate longest pod name for jobset will not exceed 63 chars #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielvegamyhre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/M
ahg-g
reviewed
Feb 13, 2024
| // Add 5 char suffix to the deterministic part of the pod name to validate the full pod name is compliant. | ||
| longestPodName := placement.GenPodName(js.Name, rjob.Name, maxJobIndex, maxPodIndex) + "-abcde" | ||
| for _, errMessage := range validation.IsDNS1035Label(longestPodName) { | ||
| allErrs = append(allErrs, fmt.Errorf(errMessage)) |
There was a problem hiding this comment.
Will the error message contain the -abcde? If so, I am afraid that will be confusing and perhaps better to have our own error message.
There was a problem hiding this comment.
I'll test and confirm really quick
There was a problem hiding this comment.
Error message looks good to me:
$ k apply -f examples/simple/test.yaml
Error from server (Forbidden): error when creating "examples/simple/exclusive-placement.yaml": admission webhook "vjobset.kb.io" denied the request: must be no more than 63 characters
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added a commit
that referenced
this pull request
Feb 13, 2024
…-#409-upstream-release-0.3 Automated cherry pick of #409: validate longest pod name for jobset will not exceed 63 chars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #408