-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update golang to 1.22 #471
Conversation
✅ Deploy Preview for kubernetes-sigs-jobset canceled.
|
/retest |
hmm. maybe we can't do this yet. |
/hold Something is not right here. |
Weird, bumping 1.22 works me locally, everything builds fine. Did it work locally for you as well? If so it must be a CI env issue, will need to investigate |
yea I wonder if the test-infra image is using 1.21.0. |
I have kubernetes/test-infra#32302 to see if that will fix the PR. |
Opened up kubernetes-sigs/kueue#1895 to see. This seems to work so please review kubernetes/test-infra#32302 when you get a chance. |
/retest |
1 similar comment
/retest |
/hold cancel Found out that kueue parametrizes BUILDER_IMAGE |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielvegamyhre, kannon92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Seems like a lot of kube dependencies are upgrading to 1.22 with kube 1.30 coming down the pipe.
Let's bump this to 1.22. We just bumped our CI to run with 1.22 image.