Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug when checking if a JobSet is active during tests. #531

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Fix bug when checking if a JobSet is active during tests. #531

merged 1 commit into from
Apr 20, 2024

Conversation

jedwins1998
Copy link
Contributor

Change checkJobSetActive function to check for JobSet conditions JobSetFailed, JobSetComplete, and JobSetSuspended as indicators that the JobSet is not active.

This fixes #530

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 18, 2024
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and kannon92 April 18, 2024 22:32
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 18, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @jedwins1998. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 18, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 18, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-jobset canceled.

Name Link
🔨 Latest commit 0320fb5
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-jobset/deploys/66229bc8f1943300082a53d0

@jedwins1998
Copy link
Contributor Author

cc @danielvegamyhre

@kannon92
Copy link
Contributor

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 18, 2024
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 18, 2024
@jedwins1998
Copy link
Contributor Author

Update as I realized the code I pushed did not match the definition I left on this comment in issue #531.

danielvegamyhre
danielvegamyhre reviewed Apr 19, 2024
View reviewed changes
test/util/util.go Outdated
forbiddenStatuses := []metav1.ConditionStatus{metav1.ConditionTrue}

for _, c := range fetchedJS.Status.Conditions {
if slices.Contains(forbiddenTypes, c.Type) && slices.Contains(forbiddenStatuses, c.Status) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these conditions must have a status of true in order to be failed/completed/suspended, so let's just directly check slices.Contains(forbiddenTypes, c.Type) && c.Status == metav1.ConditionTrue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the code.

@danielvegamyhre
Copy link
Contributor

/approve

Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielvegamyhre, jedwins1998

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2024
@danielvegamyhre
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit 07be46d into kubernetes-sigs:main Apr 20, 2024
12 checks passed
@jedwins1998 jedwins1998 deleted the testutil-update-jobsetactive branch May 21, 2024 16:19
@danielvegamyhre danielvegamyhre mentioned this pull request Aug 19, 2024
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielvegamyhre danielvegamyhre danielvegamyhre left review comments

@ahg-g ahg-g Awaiting requested review from ahg-g

@kannon92 kannon92 Awaiting requested review from kannon92

Assignees

@kannon92 kannon92

@danielvegamyhre danielvegamyhre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in testing utility function JobSetActive
4 participants
@jedwins1998 @k8s-ci-robot @kannon92 @danielvegamyhre