cleanup duplicate func

[googs1025]

/kind cleanup

• clean duplicate func

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: googs1025
Once this PR has been reviewed and has the lgtm label, please assign danielvegamyhre for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @googs1025. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-jobset canceled.

Name	Link
🔨 Latest commit	7a005fd
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-jobset/deploys/6629e7dde3d9bc00089f408b

[danielvegamyhre]

My thinking with having this function called inside the conditions instead of outside, is that it can be expensive to compute for jobsets with a large number of jobs, so maybe we don't want to unconditionally call it even if we won't end up using the result.

Anyone else have thoughts on this? @kannon92

[kannon92]

I don't think this is really needed. I like the policy to report performance numbers to really get a fix for it. This could be a premature optimization. If it comes up, its an easy fix but no reason to fix it at the moment.

[googs1025]

Understood, I was just a bit confused while reading the code, but now I understand the reason. I'll close it out. Thank you all.