Propagate Job pod template updates to suspended jobs when resuming #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielvegamyhre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/L
✅ Deploy Preview for kubernetes-sigs-jobset canceled.
|
|
@alculquicondor @ahg-g for review, please take a look when you can :) |
danielvegamyhre
added
the
tide/merge-method-merge
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Thanks! Please cherry-pick to 0.5 |
k8s-ci-robot
added a commit
that referenced
this pull request
Jun 3, 2024
…-#590-upstream-release-0.5 Automated cherry pick of #590: propagate job pod template updates to suspended jobs when
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #586
This PR refactors the JobSet controller logic (which previously only propagated Job pod template spec updates to nodeSelectors to child Jobs when resuming them) to also propagate updates to labels, annotations, and tolerations.
It also updates the relevant integration test to verify updates to all of these values are propagated correctly.