Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add component config #609

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add component config #609

wants to merge 1 commit into from

Conversation

rainfd
Copy link

@rainfd rainfd commented Jun 28, 2024

Fix: #55
The basic configuration follows kueue.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 28, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @rainfd!

It looks like this is your first PR to kubernetes-sigs/jobset 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/jobset has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 28, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @rainfd. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 28, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 28, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-jobset ready!

Name Link
🔨 Latest commit ea1ac2e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-jobset/deploys/66ab1467f981be00083b3058
😎 Deploy Preview https://deploy-preview-609--kubernetes-sigs-jobset.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ahg-g
Copy link
Contributor

ahg-g commented Jun 30, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 30, 2024
@danielvegamyhre
Copy link
Contributor

Thanks for working on this @rainfd, I will review this soon

@ahg-g ahg-g mentioned this pull request Jul 1, 2024
Open
googs1025
googs1025 reviewed Jul 3, 2024
View reviewed changes
main.go
Comment on lines +133 to +138
kubeConfig.QPS = *cfg.ClientConnection.QPS
kubeConfig.Burst = int(*cfg.ClientConnection.Burst)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the user sets both the qps flag and the configFile flag, will the qps flag not take effect? ​​Have we considered this situation?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wouldn't take effect. Only configFile and featuregate flag is support in kueue currently.
Considering supporting both configuration files and command-line arguments requires to add spf13/viper like dependencies.
I just want to keep it simple.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your reply. so, config is the first priority. Once configured, flag will not take effect.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add this comment to the description.

@danielvegamyhre danielvegamyhre self-assigned this Jul 3, 2024
@danielvegamyhre
Copy link
Contributor

FYI I am OOO for the next week or so but can review when I get back.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rainfd
Once this PR has been reviewed and has the lgtm label, please ask for approval from danielvegamyhre. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

danielvegamyhre
danielvegamyhre reviewed Jul 4, 2024
View reviewed changes
api/config/v1alpha1/configuration_types.go
Namespace *string `json:"namespace,omitempty"`

// ControllerManager returns the configurations for controllers
ControllerManager `json:",inline"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this field json tag is inline with no name, where as others are not?

Same question for other fields in the file. Is it just for making the structure of the json less nested?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your guess is right. The basic structure come from kueue, and I think it was clear, so I didn't change it

@danielvegamyhre
Copy link
Contributor

Looks good, I would prefer to include a larger change like this in 0.7 release, rather than as a last minute addition to 0.6, so unless there's any objections that's what we'll do

@danielvegamyhre
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 30, 2024
@rainfd
feat: add component config
ea1ac2e 
Signed-off-by: rainfd <rainfd@live.cn>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2024
@danielvegamyhre danielvegamyhre added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@googs1025 googs1025 googs1025 left review comments

@danielvegamyhre danielvegamyhre danielvegamyhre left review comments

@ahg-g ahg-g Awaiting requested review from ahg-g

@kannon92 kannon92 Awaiting requested review from kannon92

Assignees

@danielvegamyhre danielvegamyhre

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-0.7 size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide the component config
5 participants
@rainfd @k8s-ci-robot @ahg-g @danielvegamyhre @googs1025