Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add global-job-replicas label/annotation #677

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Add global-job-replicas label/annotation #677

merged 2 commits into from
Sep 18, 2024

Conversation

GiuseppeTT
Copy link
Contributor

/kind feature

Fixes #676

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 16, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Sep 16, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 16, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @GiuseppeTT!

It looks like this is your first PR to kubernetes-sigs/jobset 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/jobset has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 16, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @GiuseppeTT. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 16, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 16, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-jobset canceled.

Name Link
🔨 Latest commit 849160f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-jobset/deploys/66eb130c6c833800089b4807

@googs1025
Copy link
Member

/ok-to-test
@GiuseppeTT
can you fix the EasyCLA? :)

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 16, 2024
@GiuseppeTT
Copy link
Contributor Author

/ok-to-test @GiuseppeTT can you fix the EasyCLA? :)

Done : )

@danielvegamyhre
Copy link
Contributor

/lgtm

@GiuseppeTT is this going to be used to set TPU_NUM_SLICES (or similar) env var?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2024
ahg-g
ahg-g reviewed Sep 18, 2024
View reviewed changes
api/jobset/v1alpha2/jobset_types.go Outdated
// GlobalJobReplicasKey is a label/annotation set to the total number of replicatedJob replicas.
// For each JobSet, this value will be equal to the sum of `replicas`, where `replicas`
// is equal to jobset.spec.replicatedJobs[*].replicas.
GlobalJobReplicasKey string = "jobset.sigs.k8s.io/global-job-replicas"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jobset.sigs.k8s.io/global-job-count

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we used jobset.sigs.k8s.io/replicatedjob-replicas above, so the equivalent here would be jobset.sigs.k8s.io/global-replicas perhaps.

Copy link
Contributor Author

@GiuseppeTT GiuseppeTT Sep 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ahg-g.

Just to be extra sure. Are you suggesting to rename jobset.sigs.k8s.io/global-job-replicas to jobset.sigs.k8s.io/global-replicas? If so, I agree, it's a better name and I can change it : )

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, to align with the other annotation we have for number of replicas within a replicatedJob

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@GiuseppeTT
Copy link
Contributor Author

@GiuseppeTT is this going to be used to set TPU_NUM_SLICES (or similar) env var?

Yes! It is going to be used to set the env variable MEGASCALE_NUM_SLICES.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2024
@ahg-g ahg-g added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 18, 2024
@ahg-g
Copy link
Contributor

ahg-g commented Sep 18, 2024

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, GiuseppeTT

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2024
@k8s-ci-robot k8s-ci-robot merged commit ef7f910 into kubernetes-sigs:main Sep 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g ahg-g left review comments

@kannon92 kannon92 Awaiting requested review from kannon92

Assignees

@ahg-g ahg-g

@danielvegamyhre danielvegamyhre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add global replica count label/annotation to support multislice training workloads with different templates
5 participants
@GiuseppeTT @k8s-ci-robot @googs1025 @danielvegamyhre @ahg-g