-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pod Metric Testing is Flakey due to the Lack of the default
namespace
#887
Comments
This change was merged in kubernetes-sigs/controller-runtime#2668 in upstream controller-runtime. As soon as they release their next version, the hope is that we can bump and we should stop seeing flakes. |
This shouldn't be seen anymore once we get to v0.18.0 of controller-runtime. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
@jonathan-innis Do you know if we can close this out now that we're on controller-runtime |
Yep! This can be closed since the change I made to deflake this test case got merged into controller-runtime in v0.18.0! |
/close |
@jonathan-innis: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
Observed Behavior:
Karpenter testing is flaking often with failures in the pod metric testing like
An example job where this occurred can be seen here: https://github.com/kubernetes-sigs/karpenter/actions/runs/7251475446/job/19753908191?pr=885
This is being tracked upstream to see what their recommendation is e.g. whether we should do a downstream check or whether this is something that can be fixed upstream: kubernetes-sigs/controller-runtime#2626
Expected Behavior:
Tests shouldn't be flakey.
Reproduction Steps (Please include YAML):
Versions:
kubectl version
):The text was updated successfully, but these errors were encountered: