-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Convert to controller-runtime's new reconcile.AsReconciler
#1247
chore: Convert to controller-runtime's new reconcile.AsReconciler
#1247
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonathan-innis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f3d9340
to
b1a7f9a
Compare
b1a7f9a
to
1033f5f
Compare
f5ea418
to
e9fd10a
Compare
4082352
to
d756c46
Compare
b0bae40
to
9c7d33b
Compare
9c7d33b
to
3e226aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonathan-innis Do you think this can be deferred until #1050 is landed? Because there are few of the knative logging being added here which is could be converted to runtime-logging as well.
Happy to rebase the changes from this PR onto that one so that we can drop the logger injection if this gets merged first @fmuyassarov |
/lgtm |
Fixes #N/A
Description
Removes our
controller.TypedController
and replaces it with controller-runtime's typed controller implementation e.g.reconcile.AsReconciler()
How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.