feat: Machine Migration #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-innis
force-pushed
the
machine-migration
branch
30 times, most recently
from
20ba1cd
to
4ae59b6
Compare
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Mar 15, 2023
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Mar 15, 2023
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Mar 15, 2023
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Mar 15, 2023
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Mar 15, 2023
jonathan-innis
added a commit
that referenced
this pull request
Mar 15, 2023
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Mar 16, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Mar 16, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 4, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 5, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 5, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 5, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 5, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 5, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 5, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 5, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 5, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 5, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 8, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 10, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 11, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 12, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 13, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 14, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 18, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 20, 2023
…netes-sigs#241)" This reverts commit 9973eac.
njtran
pushed a commit
to njtran/karpenter
that referenced
this pull request
May 3, 2023
* Revert "Revert machine migration changes (kubernetes-sigs#176) (kubernetes-sigs#241)" This reverts commit 9973eac. * Change owner reference to blockOwnerDeletion * Remove string logging for machine launch * Removing FailedInit since machine statusCondition captures it * Updated eventing on machines
njtran
added a commit
that referenced
this pull request
May 4, 2023
* chore: cleanup deprovisioning types * add inc * fix: add more visibility for when we can't consolidate (#292) * feat: Machine Migration (#273) * Revert "Revert machine migration changes (#176) (#241)" This reverts commit 9973eac. * Change owner reference to blockOwnerDeletion * Remove string logging for machine launch * Removing FailedInit since machine statusCondition captures it * Updated eventing on machines * action const * testfix * testfix2 * comments * rename * last * enum * fixcompile * export * fixredundancy * fixlogic * comment * renameVar --------- Co-authored-by: Todd Neal <tnealt@amazon.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
This PR is the
karpenter-coreswitchover to managing the cloudprovider machine lifecycle through Karpenter as mentioned in https://github.com/aws/karpenter/blob/main/designs/node-ownership.md. At a high-level this PR does the following actions:v1alpha5.Machineto represent a scheduling decision at the end of the provisioning loopstate.StateNoderepresentation for Candidates to handle the scheduling modeling and the deprovisioning mapping to get the Machine control-plane representation of the Nodemachine.Controllerto reconcile Machines with requirements and launch them at the cloudproviderinformer.Machineto reconcile Machines into thestate.Clusternode.spec.providerIDandmachine.Status.providerIDkubectl delete node -l karpenter.sh/provisioner-namebut the termination flow is driven through the machinettlAfterNotRegisteredvalue inkarpenter-global-settingswhich self-terminates av1alpha5.Machineif the Machine doesn't have a corresponding Node within the ttl duration.How was this change tested?
make e2etestsmake presubmitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.