Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix node requeue when node is nominated #294

Merged

Conversation

jonathan-innis
Copy link
Member

Fixes #

Description

The node emptiness reconciler wouldn't requeue when the node was nominated. This meant that if a node was nominated when it went through the node emptiness sub-reconciler and there was no update to the node afterwards, there would be no requeue that would mark the node as empty. This change updates the sub-reconciler so we do a short poll during the node nomination timeframe.

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner April 14, 2023 16:56
@jonathan-innis jonathan-innis enabled auto-merge (squash) April 14, 2023 16:56
@jonathan-innis jonathan-innis force-pushed the fix-node-requeue branch 2 times, most recently from 3ef581d to 760ca67 Compare April 14, 2023 17:14
@coveralls
Copy link

coveralls commented Apr 14, 2023

Pull Request Test Coverage Report for Build 4702312322

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 14 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 81.279%

Files with Coverage Reduction New Missed Lines %
pkg/controllers/node/controller.go 2 80.88%
pkg/controllers/deprovisioning/controller.go 3 84.39%
pkg/controllers/deprovisioning/events/events.go 9 85.25%
Totals Coverage Status
Change from base Build 4699670578: -0.1%
Covered Lines: 6738
Relevant Lines: 8290

💛 - Coveralls

@jonathan-innis jonathan-innis force-pushed the fix-node-requeue branch 2 times, most recently from 423e954 to e59fe07 Compare April 14, 2023 17:20
@jonathan-innis jonathan-innis merged commit b915d90 into kubernetes-sigs:main Apr 14, 2023
@jonathan-innis jonathan-innis deleted the fix-node-requeue branch April 14, 2023 18:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants