fix: speed up labelsToString #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function shows up in profiling as taking a significant amount of time. At least for now, make is ~2x as fast. benchstat results of before -> after: name old time/op new time/op delta Original-12 32.5µs ± 1% 13.9µs ± 2% -57.26% (p=0.000 n=10+10)
|
It caught my attention when I saw this in a profile:
|
Pull Request Test Coverage Report for Build 4716234064
💛 - Coveralls |
ellistarn
approved these changes
Apr 17, 2023
|
I know @jonathan-innis is working on a metrics rewrite -- maybe it's possible to avoid this entirely (or a at a different frequency) somehow. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
This function shows up in profiling as taking a significant amount of time. At least for now, make is ~2x as fast.
benchstat results of before -> after:
How was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.