Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Propagate discovery label to pods owned by deployment #384

Merged

Conversation

jonathan-innis
Copy link
Member

Fixes #N/A

Description

  • Propagate testing.karpenter.sh discovery label to pods owned by deployment so that pods that are created through this method will be properly waited for during the cleanup phase.

How was this change tested?

/karpenter snapshot

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner June 26, 2023 06:29
@jonathan-innis jonathan-innis enabled auto-merge (squash) June 26, 2023 06:29
@coveralls
Copy link

coveralls commented Jun 26, 2023

Pull Request Test Coverage Report for Build 5374571957

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 81.577%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/test/deployment.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/node/controller.go 7 70.59%
Totals Coverage Status
Change from base Build 5349504400: -0.06%
Covered Lines: 6952
Relevant Lines: 8522

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants