chore: Reduce log spam from garbage collection

[jonathan-innis]

Fixes #N/A

Description

• Reduces log spam by removing garbage collecting machine with no cloudprovider representation... when the Machine on the cluster already has its DeletionTimestamp set.

Before the Change

        2023-07-03T06:51:04.069Z        INFO    controller.machine.termination  deleted machine {"commit": "fd312fe", "machine": "gargoylerowan-2-k4achn7nrr-5ptwq", "node": "ip-192-168-85-31.us-west-2.compute.internal", "provisioner": "gargoy
lerowan-2-k4achn7nrr", "provider-id": "aws:///us-west-2d/i-080f5613bc4270047"}
        2023-07-03T06:51:04.075Z        INFO    controller.machine.termination  deleted machine {"commit": "fd312fe", "machine": "gargoylerowan-2-k4achn7nrr-x8mvl", "node": "ip-192-168-95-12.us-west-2.compute.internal", "provisioner": "gargoy
lerowan-2-k4achn7nrr", "provider-id": "aws:///us-west-2d/i-0f1b9bc28eb66e52f"}
        2023-07-03T06:51:04.080Z        INFO    controller.machine.termination  deleted machine {"commit": "fd312fe", "machine": "gargoylerowan-2-k4achn7nrr-925xx", "node": "ip-192-168-148-21.us-west-2.compute.internal", "provisioner": "gargo
ylerowan-2-k4achn7nrr", "provider-id": "aws:///us-west-2a/i-003987e14ade67c7f"}
        2023-07-03T06:51:04.083Z        INFO    controller.machine.termination  deleted machine {"commit": "fd312fe", "machine": "gargoylerowan-2-k4achn7nrr-49nx6", "node": "ip-192-168-137-28.us-west-2.compute.internal", "provisioner": "gargo
ylerowan-2-k4achn7nrr", "provider-id": "aws:///us-west-2a/i-0ad0823f3959d7f59"}
        2023-07-03T06:51:04.093Z        INFO    controller.machine.termination  deleted machine {"commit": "fd312fe", "machine": "gargoylerowan-2-k4achn7nrr-7cwkj", "node": "ip-192-168-159-66.us-west-2.compute.internal", "provisioner": "gargo
ylerowan-2-k4achn7nrr", "provider-id": "aws:///us-west-2a/i-0863a81a098b1a2d5"}
        2023-07-03T06:51:04.095Z        ERROR   controller      Reconciler error        {"commit": "fd312fe", "controller": "node_state", "controllerGroup": "", "controllerKind": "Node", "Node": {"name":"ip-192-168-90-48.us-west-2.compute.int
ernal"}, "namespace": "", "name": "ip-192-168-90-48.us-west-2.compute.internal", "reconcileID": "97f77ef1-7b50-4ce7-9e38-acae3ac03ea2", "error": "getting providerRef, AWSNodeTemplate.karpenter.k8s.aws \"wizardgold-1-1hsutfdehk\" not found"}
        2023-07-03T06:51:04.097Z        INFO    controller.machine.termination  deleted machine {"commit": "fd312fe", "machine": "gargoylerowan-2-k4achn7nrr-vq2ls", "node": "ip-192-168-148-221.us-west-2.compute.internal", "provisioner": "garg
oylerowan-2-k4achn7nrr", "provider-id": "aws:///us-west-2a/i-0cc2f3b8e28cadee8"}
        2023-07-03T06:51:04.098Z        INFO    controller.machine.termination  deleted machine {"commit": "fd312fe", "machine": "gargoylerowan-2-k4achn7nrr-sqsmx", "node": "ip-192-168-89-30.us-west-2.compute.internal", "provisioner": "gargoy
lerowan-2-k4achn7nrr", "provider-id": "aws:///us-west-2d/i-0bed072e1b30f0239"}
        2023-07-03T06:51:04.104Z        INFO    controller.machine.termination  deleted machine {"commit": "fd312fe", "machine": "gargoylerowan-2-k4achn7nrr-4qd9v", "node": "ip-192-168-135-87.us-west-2.compute.internal", "provisioner": "gargo
ylerowan-2-k4achn7nrr", "provider-id": "aws:///us-west-2a/i-0279857f0cf16570c"}
        2023-07-03T06:51:04.112Z        INFO    controller.machine.termination  deleted machine {"commit": "fd312fe", "machine": "gargoylerowan-2-k4achn7nrr-px4dg", "node": "ip-192-168-89-52.us-west-2.compute.internal", "provisioner": "gargoy
lerowan-2-k4achn7nrr", "provider-id": "aws:///us-west-2d/i-0e28e6d44b60004df"}
        2023-07-03T06:51:04.113Z        INFO    controller.machine.termination  deleted machine {"commit": "fd312fe", "machine": "gargoylerowan-2-k4achn7nrr-s2sk9", "node": "ip-192-168-147-50.us-west-2.compute.internal", "provisioner": "gargo
ylerowan-2-k4achn7nrr", "provider-id": "aws:///us-west-2a/i-096bb85a5e0ff817a"}
        2023-07-03T06:51:04.121Z        INFO    controller.machine.termination  deleted machine {"commit": "fd312fe", "machine": "gargoylerowan-2-k4achn7nrr-59qsv", "node": "ip-192-168-154-122.us-west-2.compute.internal", "provisioner": "garg
oylerowan-2-k4achn7nrr", "provider-id": "aws:///us-west-2a/i-0f1aa062897db63e5"}
        2023-07-03T06:51:04.124Z        INFO    controller.machine.termination  deleted machine {"commit": "fd312fe", "machine": "gargoylerowan-2-k4achn7nrr-gkxkf", "node": "ip-192-168-90-118.us-west-2.compute.internal", "provisioner": "gargo
ylerowan-2-k4achn7nrr", "provider-id": "aws:///us-west-2d/i-0d92bc2bc4cb3d125"}
        2023-07-03T06:51:04.127Z        INFO    controller.machine.termination  deleted machine {"commit": "fd312fe", "machine": "gargoylerowan-2-k4achn7nrr-27bl6", "node": "ip-192-168-92-167.us-west-2.compute.internal", "provisioner": "gargo
ylerowan-2-k4achn7nrr", "provider-id": "aws:///us-west-2d/i-0f33ec4218d7ee9f5"}
        2023-07-03T06:51:04.133Z        INFO    controller.machine.termination  deleted machine {"commit": "fd312fe", "machine": "gargoylerowan-2-k4achn7nrr-sx5d5", "node": "ip-192-168-144-202.us-west-2.compute.internal", "provisioner": "garg
oylerowan-2-k4achn7nrr", "provider-id": "aws:///us-west-2a/i-0dac7933014affb06"}
        2023-07-03T06:51:04.140Z        INFO    controller.machine.termination  deleted machine {"commit": "fd312fe", "machine": "gargoylerowan-2-k4achn7nrr-9nf9g", "node": "ip-192-168-143-31.us-west-2.compute.internal", "provisioner": "gargo
ylerowan-2-k4achn7nrr", "provider-id": "aws:///us-west-2a/i-0bab3d98ac5402333"}
        2023-07-03T06:51:04.144Z        INFO    controller.machine.termination  deleted machine {"commit": "fd312fe", "machine": "gargoylerowan-2-k4achn7nrr-lfdwc", "node": "ip-192-168-73-138.us-west-2.compute.internal", "provisioner": "gargo
ylerowan-2-k4achn7nrr", "provider-id": "aws:///us-west-2d/i-0e6723ce6697a2592"}
        2023-07-03T06:51:04.149Z        INFO    controller.machine.termination  deleted machine {"commit": "fd312fe", "machine": "gargoylerowan-2-k4achn7nrr-7wwc8", "node": "ip-192-168-77-215.us-west-2.compute.internal", "provisioner": "gargo
ylerowan-2-k4achn7nrr", "provider-id": "aws:///us-west-2d/i-07fe827e0b2a01124"}
        2023-07-03T06:51:04.159Z        INFO    controller.machine.termination  deleted machine {"commit": "fd312fe", "machine": "gargoylerowan-2-k4achn7nrr-ffltf", "node": "ip-192-168-140-250.us-west-2.compute.internal", "provisioner": "garg
oylerowan-2-k4achn7nrr", "provider-id": "aws:///us-west-2a/i-08e08eff807b6399b"}
        2023-07-03T06:51:04.159Z        INFO    controller.machine.termination  deleted machine {"commit": "fd312fe", "machine": "gargoylerowan-2-k4achn7nrr-znscq", "node": "ip-192-168-144-253.us-west-2.compute.internal", "provisioner": "garg
oylerowan-2-k4achn7nrr", "provider-id": "aws:///us-west-2a/i-0a49178b8761d2cff"}
        2023-07-03T06:51:04.168Z        INFO    controller.machine.termination  deleted machine {"commit": "fd312fe", "machine": "gargoylerowan-2-k4achn7nrr-lrf96", "node": "ip-192-168-83-247.us-west-2.compute.internal", "provisioner": "gargo
ylerowan-2-k4achn7nrr", "provider-id": "aws:///us-west-2d/i-026fb9a493e7e745a"}
        2023-07-03T06:51:04.170Z        INFO    controller.machine.termination  deleted machine {"commit": "fd312fe", "machine": "gargoylerowan-2-k4achn7nrr-bc8wd", "node": "ip-192-168-67-74.us-west-2.compute.internal", "provisioner": "gargoy
lerowan-2-k4achn7nrr", "provider-id": "aws:///us-west-2d/i-0fe533022f194ea00"}
        2023-07-03T06:51:04.174Z        INFO    controller.machine.termination  deleted machine {"commit": "fd312fe", "machine": "gargoylerowan-2-k4achn7nrr-glp56", "node": "ip-192-168-92-94.us-west-2.compute.internal", "provisioner": "gargoy
lerowan-2-k4achn7nrr", "provider-id": "aws:///us-west-2d/i-08d39019ebcd5f986"}
        2023-07-03T06:51:04.179Z        INFO    controller.machine.termination  deleted machine {"commit": "fd312fe", "machine": "gargoylerowan-2-k4achn7nrr-b2gvm", "node": "ip-192-168-95-172.us-west-2.compute.internal", "provisioner": "gargo
ylerowan-2-k4achn7nrr", "provider-id": "aws:///us-west-2d/i-0c3ba7c9962e436a7"}
        2023-07-03T06:51:04.188Z        INFO    controller.machine.termination  deleted machine {"commit": "fd312fe", "machine": "gargoylerowan-2-k4achn7nrr-wmvhd", "node": "ip-192-168-152-253.us-west-2.compute.internal", "provisioner": "garg
oylerowan-2-k4achn7nrr", "provider-id": "aws:///us-west-2a/i-00ce8ec0c24e64bdf"}
        2023-07-03T06:51:04.246Z        DEBUG   controller.machine.garbagecollection    garbage collecting machine with no cloudprovider representation {"commit": "fd312fe", "provisioner": "gargoylerowan-2-k4achn7nrr", "machine": "gargoylerow
an-2-k4achn7nrr-5wczl", "provider-id": "aws:///us-west-2d/i-08fe24ca84ef582b9"}
        2023-07-03T06:51:04.425Z        DEBUG   controller.machine.garbagecollection    garbage collecting machine with no cloudprovider representation {"commit": "fd312fe", "provisioner": "gargoylerowan-2-k4achn7nrr", "machine": "gargoylerow
an-2-k4achn7nrr-l7rlz", "provider-id": "aws:///us-west-2d/i-01af82fcbac546ba5"}
        2023-07-03T06:51:04.426Z        DEBUG   controller.machine.garbagecollection    garbage collecting machine with no cloudprovider representation {"commit": "fd312fe", "provisioner": "gargoylerowan-2-k4achn7nrr", "machine": "gargoylerow
an-2-k4achn7nrr-xggz5", "provider-id": "aws:///us-west-2d/i-06454baddb6bd898b"}
        2023-07-03T06:51:04.435Z        DEBUG   controller.machine.garbagecollection    garbage collecting machine with no cloudprovider representation {"commit": "fd312fe", "provisioner": "gargoylerowan-2-k4achn7nrr", "machine": "gargoylerow
an-2-k4achn7nrr-zbt48", "provider-id": "aws:///us-west-2d/i-018e620f07e52618f"}
        2023-07-03T06:51:04.439Z        DEBUG   controller.machine.garbagecollection    garbage collecting machine with no cloudprovider representation {"commit": "fd312fe", "provisioner": "gargoylerowan-2-k4achn7nrr", "machine": "gargoylerow
an-2-k4achn7nrr-nbqfp", "provider-id": "aws:///us-west-2d/i-0a13eaf32cf0cb6ba"}
        2023-07-03T06:51:04.445Z        DEBUG   controller.machine.garbagecollection    garbage collecting machine with no cloudprovider representation {"commit": "fd312fe", "provisioner": "gargoylerowan-2-k4achn7nrr", "machine": "gargoylerow
an-2-k4achn7nrr-nrrqf", "provider-id": "aws:///us-west-2b/i-02017e166567a5721"}
        2023-07-03T06:51:04.453Z        DEBUG   controller.machine.garbagecollection    garbage collecting machine with no cloudprovider representation {"commit": "fd312fe", "provisioner": "gargoylerowan-2-k4achn7nrr", "machine": "gargoylerow
an-2-k4achn7nrr-x8mvl", "provider-id": "aws:///us-west-2d/i-0f1b9bc28eb66e52f"}
        2023-07-03T06:51:04.456Z        DEBUG   controller.machine.garbagecollection    garbage collecting machine with no cloudprovider representation {"commit": "fd312fe", "provisioner": "gargoylerowan-2-k4achn7nrr", "machine": "gargoylerow
an-2-k4achn7nrr-v84s5", "provider-id": "aws:///us-west-2d/i-00387e7cef45a1391"}
        2023-07-03T06:51:04.462Z        DEBUG   controller.machine.garbagecollection    garbage collecting machine with no cloudprovider representation {"commit": "fd312fe", "provisioner": "gargoylerowan-2-k4achn7nrr", "machine": "gargoylerow
an-2-k4achn7nrr-pg4gx", "provider-id": "aws:///us-west-2d/i-004622be7935ec6c1"}
        2023-07-03T06:51:04.469Z        DEBUG   controller.machine.garbagecollection    garbage collecting machine with no cloudprovider representation {"commit": "fd312fe", "provisioner": "gargoylerowan-2-k4achn7nrr", "machine": "gargoylerow
an-2-k4achn7nrr-kwtnw", "provider-id": "aws:///us-west-2d/i-05005b31e2cd6f319"}
        2023-07-03T06:51:04.471Z        DEBUG   controller.machine.garbagecollection    garbage collecting machine with no cloudprovider representation {"commit": "fd312fe", "provisioner": "gargoylerowan-2-k4achn7nrr", "machine": "gargoylerow
an-2-k4achn7nrr-4464w", "provider-id": "aws:///us-west-2a/i-0963417a884e12604"}
        2023-07-03T06:51:04.479Z        DEBUG   controller.machine.garbagecollection    garbage collecting machine with no cloudprovider representation {"commit": "fd312fe", "provisioner": "gargoylerowan-2-k4achn7nrr", "machine": "gargoylerow
an-2-k4achn7nrr-87fh8", "provider-id": "aws:///us-west-2d/i-030ad899254b9d835"}
        2023-07-03T06:51:04.484Z        DEBUG   controller.machine.garbagecollection    garbage collecting machine with no cloudprovider representation {"commit": "fd312fe", "provisioner": "gargoylerowan-2-k4achn7nrr", "machine": "gargoylerow
an-2-k4achn7nrr-txs5v", "provider-id": "aws:///us-west-2a/i-01542d41b7cd05c4e"}
        2023-07-03T06:51:04.487Z        DEBUG   controller.machine.garbagecollection    garbage collecting machine with no cloudprovider representation {"commit": "fd312fe", "provisioner": "gargoylerowan-2-k4achn7nrr", "machine": "gargoylerow
an-2-k4achn7nrr-ffltf", "provider-id": "aws:///us-west-2a/i-08e08eff807b6399b"}
        2023-07-03T06:51:04.490Z        DEBUG   controller.machine.garbagecollection    garbage collecting machine with no cloudprovider representation {"commit": "fd312fe", "provisioner": "gargoylerowan-2-k4achn7nrr", "machine": "gargoylerow
an-2-k4achn7nrr-sj8nc", "provider-id": "aws:///us-west-2a/i-0fddaa309d5fa7472"}
        2023-07-03T06:51:04.500Z        DEBUG   controller.machine.garbagecollection    garbage collecting machine with no cloudprovider representation {"commit": "fd312fe", "provisioner": "gargoylerowan-2-k4achn7nrr", "machine": "gargoylerow
an-2-k4achn7nrr-kqcqx", "provider-id": "aws:///us-west-2a/i-0be5ee8b05662219b"}
        2023-07-03T06:51:04.510Z        DEBUG   controller.machine.garbagecolle

How was this change tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[coveralls]

Pull Request Test Coverage Report for Build 5446775356

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.02%) to 81.608%

---

Files with Coverage Reduction	New Missed Lines	%
pkg/test/cachesyncingclient.go	2	82.47%

Totals
Change from base Build 5426283929:	-0.02%
Covered Lines:	6975
Relevant Lines:	8547

---

💛 - Coveralls