Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow disabling webhooks #399

Merged
merged 2 commits into from
Jul 7, 2023
Merged

allow disabling webhooks #399

merged 2 commits into from
Jul 7, 2023

Conversation

tzneal
Copy link
Contributor

@tzneal tzneal commented Jul 7, 2023

Fixes #N/A

Description

How was this change tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tzneal tzneal requested a review from a team as a code owner July 7, 2023 13:50
@coveralls
Copy link

coveralls commented Jul 7, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5487979727

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.689%
Totals Coverage Status
Change from base Build 5483263079: 0.0%
Covered Lines: 6982
Relevant Lines: 8547
💛 - Coveralls

bwagner5
bwagner5 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tzneal tzneal merged commit 9d5d943 into kubernetes-sigs:main Jul 7, 2023
6 checks passed
@tzneal tzneal deleted the allow-disabling-webhooks branch July 7, 2023 17:39
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwagner5 bwagner5 bwagner5 approved these changes

@jonathan-innis jonathan-innis Awaiting requested review from jonathan-innis jonathan-innis was automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tzneal @coveralls @bwagner5