Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use kube-apiserver v1.25.16 for k8s 1.25 CI #833

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

jmdeal
Copy link
Member

@jmdeal jmdeal commented Nov 30, 2023

Fixes #803

Description
This PR downloads kube-apiserver v1.25.16 for use with envtest when running CI jobs for k8s 1.25.

How was this change tested?
Running GitHub actions after opening the PR.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 30, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 30, 2023
@jmdeal jmdeal changed the title test: use latest apiserver for v1.25 tests ci: use kube-apiserver v1.25.16 for k8s 1.25 CI Nov 30, 2023
.github/workflows/presubmit.yaml Outdated Show resolved Hide resolved
.github/workflows/presubmit.yaml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 1, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 1, 2023
@k8s-ci-robot
Copy link
Contributor

@jmdeal: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-karpenter-test-1-29 6b2ee0f link false /test pull-karpenter-test-1-29
pull-karpenter-test-1-26 6b2ee0f link false /test pull-karpenter-test-1-26
pull-karpenter-test-1-28 6b2ee0f link false /test pull-karpenter-test-1-28
pull-karpenter-test-1-27 6b2ee0f link false /test pull-karpenter-test-1-27

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thanks so much! Awesome work here!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmdeal, jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2023
@jonathan-innis
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7bd6e29 into kubernetes-sigs:main Dec 3, 2023
8 of 12 checks passed
@jmdeal jmdeal deleted the envtest-1.25-fix branch December 4, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transient Failures in CI for K8S_VERSION 1.25
3 participants