Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group spread methods with a common functionality into packages. #506

Open
1 task done
Tracked by #603
ybettan opened this issue Aug 7, 2023 · 4 comments
Open
1 task done
Tracked by #603

Group spread methods with a common functionality into packages. #506

ybettan opened this issue Aug 7, 2023 · 4 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Milestone
v2.1

Comments

@ybettan
Copy link
Contributor

ybettan commented Aug 7, 2023 •
edited by qbarrand

With the ongoing effort of creating more micro-controllers, and having a reconcileHelper non-exported interface for few of them we are starting to see some code duplication.

In addition to that, we can also see some standalone methods sharing the scope in the utils package.

We agreed that those kind of methods/function should be gathered into packages with their own interfaces to be used as internal libraries for other packages.

Tasks
Beta Give feedback
  1. Create the node package. #507
qbarrand added a commit to qbarrand/kernel-module-management that referenced this issue Nov 8, 2023
@qbarrand
Upgrade Kubernetes libraries to 0.26.4 (kubernetes-sigs#506)
720a04e 
OCP 4.13 is based on Kubernetes 1.26.
Use generic sets.
Bump other dependencies.
@qbarrand qbarrand mentioned this issue Jan 23, 2024
Closed
3 tasks
@qbarrand qbarrand added this to the v2.1 milestone Jan 23, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 22, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 22, 2024
@ybettan
Copy link
Contributor Author

ybettan commented May 23, 2024

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 23, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
KMM
Status: No status
Milestone
v2.1
Development

No branches or pull requests
4 participants
@qbarrand @k8s-ci-robot @ybettan @k8s-triage-robot