Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signing Dockerfile #324

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Conversation

qbarrand
Copy link
Contributor

@qbarrand qbarrand commented Mar 2, 2023

Fix the path to the sign-file binary.
Build the signing image in CI.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qbarrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 2, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2023
@netlify
Copy link

netlify bot commented Mar 2, 2023

Deploy Preview for kubernetes-sigs-kmm ready!

Name Link
🔨 Latest commit 4c57ddc
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kmm/deploys/6401fe36ac280700085463b1
😎 Deploy Preview https://deploy-preview-324--kubernetes-sigs-kmm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@4343445). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #324   +/-   ##
=======================================
  Coverage        ?   82.92%           
=======================================
  Files           ?       26           
  Lines           ?     2753           
  Branches        ?        0           
=======================================
  Hits            ?     2283           
  Misses          ?      380           
  Partials        ?       90           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@qbarrand qbarrand force-pushed the fix-signing branch 5 times, most recently from c42e568 to 5cf9ba2 Compare March 2, 2023 09:48
@qbarrand qbarrand marked this pull request as draft March 2, 2023 09:49
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 2, 2023
.github/workflows/e2e.yaml Outdated Show resolved Hide resolved
.github/workflows/e2e.yaml Outdated Show resolved Hide resolved
.github/workflows/e2e.yaml Outdated Show resolved Hide resolved
.github/workflows/e2e.yaml Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@qbarrand qbarrand force-pushed the fix-signing branch 3 times, most recently from 8744ff3 to 7fe7b05 Compare March 2, 2023 22:51
@qbarrand qbarrand marked this pull request as ready for review March 2, 2023 22:59
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 2, 2023
Fix the path to the sign-file binary.
Build the signing image in CI.
@ybettan
Copy link
Contributor

ybettan commented Mar 6, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2023
@ybettan
Copy link
Contributor

ybettan commented Mar 6, 2023

/test ?

@k8s-ci-robot
Copy link
Contributor

@ybettan: The following commands are available to trigger required jobs:

  • /test pull-kernel-module-management-build
  • /test pull-kernel-module-management-check-api-changes
  • /test pull-kernel-module-management-check-commits-count
  • /test pull-kernel-module-management-lint
  • /test pull-kernel-module-management-unit-tests

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qbarrand qbarrand merged commit 5fd8f83 into kubernetes-sigs:main Mar 6, 2023
@qbarrand qbarrand deleted the fix-signing branch March 6, 2023 09:00
qbarrand added a commit to qbarrand/kernel-module-management that referenced this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants