Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an enhancement for checking image existence using the container-runtime. #915

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

ybettan
Copy link
Contributor

@ybettan ybettan commented Oct 6, 2024

@k8s-ci-robot
Copy link
Contributor

@ybettan: GitHub didn't allow me to request PR reviews from the following users: TomerNewman.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:


/cc @yevgeny-shnaidman @mresvanis @TomerNewman

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ybettan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 6, 2024
Copy link

netlify bot commented Oct 6, 2024

Deploy Preview for kubernetes-sigs-kmm ready!

Name Link
🔨 Latest commit 781f79e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kmm/deploys/67066549be756900080d3f28
😎 Deploy Preview https://deploy-preview-915--kubernetes-sigs-kmm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.62%. Comparing base (fa23a9b) to head (781f79e).
Report is 131 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #915      +/-   ##
==========================================
- Coverage   79.09%   72.62%   -6.48%     
==========================================
  Files          51       65      +14     
  Lines        5109     4493     -616     
==========================================
- Hits         4041     3263     -778     
- Misses        882     1045     +163     
+ Partials      186      185       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yevgeny-shnaidman
Copy link
Contributor

There is one more scenario that we need to handle:

  1. user creates a KMM module
  2. Module NMC creates a MIC
  3. MIC controller tries to pull the image, image is missing and the MIC status is updated accordingly
  4. user creates an images in the repo
  5. user triggers module's reconcilaition
  6. MIC reconciliation is not triggered since MIC spec is not changed

We might consider adding some counter to the MIC spec , so that Module NMC might update it and thus trigger reconciliation.

@ybettan ybettan force-pushed the kmm-refactor branch 7 times, most recently from b3f5ac8 to c90366d Compare October 7, 2024 20:50
…r-runtime.

Signed-off-by: Yoni Bettan <yonibettan@gmail.com>
@yevgeny-shnaidman
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit c2fa641 into kubernetes-sigs:main Oct 9, 2024
22 checks passed
@ybettan ybettan deleted the kmm-refactor branch October 9, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants