-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow to load container images from stdin #2041
Conversation
add the option to pipe files to the kind load image-archive, specifying "-" as the archive name. This allows the users to load any kind of images using the common container providers export tools, i.e. podman and docker save, or more specialized tools like skopeo.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ok, this is interesting, there is a deadlock somewhere with podman, it hangs if I do
but it also doesn´t allow me to execute new podman commands 🤔 it is possible that this is the strace of the hanging command, it only happens if I use
|
In a shell I currently recommend using command substitution which is buffered IIRC |
@aojea Does |
yeah, it invokes
|
/hold |
@aojea That does sound like something that could run afoul of the locking in c/storage - most of our complaints there are around Podman blocking until an image pull is complete, but saving an image sounds like a very similar codepath. @saschagrunert has been working on a PR to improve the locking situation but I'm not certain it would resolve this case. |
I opened the issue in podman so it doesn´t get lost in this PR, will ping Sascha there, |
ahh I see the issue was closed, :) let me read it |
I don't think there's a deadlock in c/storage. The ouput of
|
naive question and just for curiosity, why |
It needs to access the storage to list containers. We are working on improving the locking and optimize certain paths to be accessed concurrently but some command combinations may still yield such livelocks. I think we should clarify that in the man pages and help message. |
it´s ok, this is working as expected then. |
would that ^ work? |
laziness???? 😄
That will work, actually, this is how this was implemented |
Excellent! Thanks a lot, @aojea 👍 |
add the option to pipe files to the kind load image-archive,
specifying "-" as the archive name.
This allows the users to load any kind of images using the common
container providers export tools, i.e. podman and docker save, or
more specialized tools like skopeo.
Fixes: #2038