-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load: support loading images with different providers (podman
)
#2728
Conversation
As of now kind hardcodes looking and loading images from `docker` as a result `kind load docker-image <image>:<tag>` does not works well when `Provider` is configured as `podman` instead of `docker`. Following PR makes sure that `kind` supports loading images irrespective of the providers configured and works for both `podman` and `docker` Signed-off-by: flouthoc <flouthoc.git@gmail.com>
Hi @flouthoc. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: flouthoc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Created a bug so it can be tracked even if PR is closed: #2729 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing this until there is a final design discussed in upstream and this is not a blocker for my use-case so this can wait.
As of now
kind
hardcodes looking and loading images fromdocker
as a result
kind load docker-image <image>:<tag>
does not works well whenProvider
is configured aspodman
instead ofdocker
.Following PR makes sure that
kind
supports loading images irrespective ofthe providers configured and works for both
podman
anddocker
Closes: #2729