Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load: support loading images with different providers (podman) #2728

Closed
wants to merge 1 commit into from

Conversation

flouthoc
Copy link
Contributor

@flouthoc flouthoc commented Apr 26, 2022

As of now kind hardcodes looking and loading images from docker
as a result kind load docker-image <image>:<tag> does not works well when
Provider is configured as podman instead of docker.

Following PR makes sure that kind supports loading images irrespective of
the providers configured and works for both podman and docker

Closes: #2729

As of now kind hardcodes looking and loading images from `docker`
as a result `kind load docker-image <image>:<tag>` does not works well when
`Provider` is configured as `podman` instead of `docker`.

Following PR makes sure that `kind` supports loading images irrespective of
the providers configured and works for both `podman` and `docker`

Signed-off-by: flouthoc <flouthoc.git@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 26, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @flouthoc. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested a review from amwat April 26, 2022 18:14
@k8s-ci-robot k8s-ci-robot added the area/provider/docker Issues or PRs related to docker label Apr 26, 2022
@k8s-ci-robot k8s-ci-robot requested a review from aojea April 26, 2022 18:14
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: flouthoc
To complete the pull request process, please assign munnerz after the PR has been reviewed.
You can assign the PR to them by writing /assign @munnerz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/provider/podman Issues or PRs related to podman size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 26, 2022
@flouthoc
Copy link
Contributor Author

Created a bug so it can be tracked even if PR is closed: #2729

@BenTheElder
Copy link
Member

#2729 (comment)

@BenTheElder
Copy link
Member

  1. this is a breaking change, some projects like kubernetes require docker to build images, but the user may opt to create the cluster with podman (it's possible to install both), after this change loading the images would no longer work. there's an outline for a new unified image load command in unified image loading: podman/docker/nerdctl/tarball #2038
  2. image saving isn't necessarily a property of node providers, we should not move it there as discussed in unified image loading: podman/docker/nerdctl/tarball #2038, you could imagine a provider using say ingnite, kubectl pods or other where we can still run containers but not obtain images, and I should really be able to load across docker image x podman nodes and podman build x docker nodes (it's admittedly likely niche, but we might as well make it simple to handle because someone is going to want this and it shouldn't be difficult to implement or maintain).

Copy link
Contributor Author

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing this until there is a final design discussed in upstream and this is not a blocker for my use-case so this can wait.

@flouthoc flouthoc closed this Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/docker Issues or PRs related to docker area/provider/podman Issues or PRs related to podman cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

load: kind load docker-image .. is non-functional for provider podman
3 participants