Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert dependency management to go modules #299

Merged
merged 5 commits into from
Feb 14, 2019

Conversation

BenTheElder
Copy link
Member

  • we're still using vendor/ for now, all of the scripts respect this except hack/{update,verify}-deps.sh
  • we no longer need to vendor dep
  • go 1.11+ is required to manage dependencies (but was already required for proper gofmt)

TODO:

  • module proof how we interact with kubernetes (finding and building it)
  • eliminate vendor and switch to a module cache proxy? 🤔
  • update docs

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 14, 2019
@BenTheElder
Copy link
Member Author

cc @neolit123
I was vendoring CRI to add mounts and not happy with how that was being pruned with dep so I kinda just went all in and bit the bullet on go modules.

@neolit123
Copy link
Member

neolit123 commented Feb 14, 2019

I was vendoring CRI to add mounts and not happy with how that was being pruned with dep so I kinda just went all in and bit the bullet on go modules.

+1
the sooner modules are adapted the better.
handling k/k will be interesting. i foresee hacks.

@BenTheElder
Copy link
Member Author

/retest
note: working with go.mod requires go >= 1.11.4 (to avoid checksum mismatches, there are bugs in earlier go 1.11 versions)

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

i guess i need to update to .4 too.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 14, 2019
@BenTheElder
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2019
@k8s-ci-robot k8s-ci-robot merged commit 85200f5 into kubernetes-sigs:master Feb 14, 2019
@BenTheElder BenTheElder deleted the modules branch July 19, 2020 23:48
stg-0 pushed a commit to stg-0/kind that referenced this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants